[test fixlet] Add tests for the zoom icon in the location bar on GTK.

chrome/chrome_tests.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'variables' : {
     'pyautolib_sources': [
       'app/chrome_command_ids.h',
       'app/chrome_dll_resource.h',
       'common/automation_constants.h',
       'common/pref_names.cc',
@@ skipping 491 matching lines @@
       ],
       'sources': [
         'browser/browser_focus_uitest.cc',
         'browser/browser_keyevents_browsertest.cc',
         'browser/instant/instant_browsertest.cc',
         'browser/mouseleave_browsertest.cc',
         'browser/printing/print_dialog_cloud_interative_uitest.cc',
         'browser/task_manager/task_manager_browsertest_util.cc',
         'browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc',
         'browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc',
+        'browser/ui/gtk/zoom_bubble_gtk_browsertest.cc',
         'browser/ui/omnibox/omnibox_view_browsertest.cc',
         'browser/ui/panels/detached_panel_browsertest.cc',
         'browser/ui/panels/docked_panel_browsertest.cc',
         'browser/ui/panels/panel_and_desktop_notification_browsertest.cc',
         'browser/ui/panels/panel_browsertest.cc',
         'browser/ui/panels/panel_drag_browsertest.cc',
         'browser/ui/panels/panel_resize_browsertest.cc',
         'browser/ui/views/bookmarks/bookmark_bar_view_test.cc',
         'browser/ui/views/button_dropdown_test.cc',
         'browser/ui/views/find_bar_host_interactive_uitest.cc',
@@ skipping 2517 matching lines @@
         'browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm',
         'browser/ui/cocoa/view_id_util_browsertest.mm',
         'browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm',
         'browser/ui/cocoa/applescript/window_applescript_test.mm',
         'browser/ui/cocoa/web_intent_sheet_controller_browsertest.mm',
         'browser/ui/cocoa/browser_window_controller_browsertest.mm',
         'browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm',
         'browser/ui/find_bar/find_bar_host_browsertest.cc',
         'browser/ui/fullscreen/fullscreen_controller_browsertest.cc',
         'browser/ui/global_error/global_error_service_browsertest.cc',
+        'browser/ui/gtk/bubble/bubble_gtk_browsertest.cc',
+        'browser/ui/gtk/confirm_bubble_gtk_browsertest.cc',
+        'browser/ui/gtk/location_bar_view_gtk_browsertest.cc',
         'browser/ui/gtk/one_click_signin_bubble_gtk_browsertest.cc',
         'browser/ui/gtk/view_id_util_browsertest.cc',
         'browser/ui/intents/web_intent_picker_controller_browsertest.cc',
         'browser/ui/login/login_prompt_browsertest.cc',
         'browser/ui/prefs/prefs_tab_helper_browsertest.cc',
         'browser/ui/startup/startup_browser_creator_browsertest.cc',
         'browser/ui/tab_modal_confirm_dialog_browsertest.cc',
         'browser/ui/tab_modal_confirm_dialog_browsertest.h',
         'browser/ui/views/ash/browser_non_client_frame_view_ash_browsertest.cc',
         'browser/ui/views/autofill/autofill_external_delegate_views_browsertest.cc',
@@ skipping 294 matching lines @@
           'sources': [
             # TODO(estade): port to win/mac.
             'browser/ui/webui/constrained_web_dialog_ui_browsertest.cc',
           ],
         }],
         ['toolkit_uses_gtk == 1 or chromeos==1 or (OS=="linux" and use_aura==1)', {
           'dependencies': [
             '../build/linux/system.gyp:ssl',
           ],
         }],
-        ['toolkit_uses_gtk == 1 and toolkit_views == 0', {
-          'sources': [
-            # BubbleGtk is used only on Linux/GTK.
-            'browser/ui/gtk/bubble/bubble_gtk_browsertest.cc',
-            'browser/ui/gtk/confirm_bubble_gtk_browsertest.cc',

[Evan Stade, 2012/10/02 18:35:59]

shouldn't the /gtk/ directory be enough to make these compile on gtk only?

[Dan Beam, 2012/10/02 19:34:14]

you'd think so. so that means this is OK to remove, then, right?

[Lei Zhang, 2012/10/02 19:56:25]

Ya. I'd still leave the filename_rules.gypi change as is, in case there are gtk
tests outside of a gtk directory.

-          ],
-        }],
         ['OS=="mac"', {
           'include_dirs': [
             '../third_party/GTM',
           ],
           # TODO(mark): We really want this for all non-static library
           # targets, but when we tried to pull it up to the common.gypi
           # level, it broke other things like the ui, startup, and
           # page_cycler tests. *shrug*
           'xcode_settings': {
             'OTHER_LDFLAGS': [
@@ skipping 1480 matching lines @@
                 '--result', '<@(_outputs)',
                 '--isolate', 'browser_tests.isolate',
               ],
             },
           ],
         },
       ],
     }],
   ],  # 'conditions'
 }