Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 10985041: DevTools: request page thumbnails from the devtools handler delegate, do not redirect to chrome://t… (Closed)

Created:
8 years, 2 months ago by pfeldman
Modified:
8 years, 2 months ago
Reviewers:
jam, yurys
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

DevTools: request page thumbnails from the devtools handler delegate, do not redirect to chrome://thumb. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158982

Patch Set 1 #

Patch Set 2 : Android delegate updated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -3 lines) Patch
M chrome/browser/android/devtools_server.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/debugger/browser_list_tabcontents_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/debugger/browser_list_tabcontents_provider.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M content/browser/debugger/devtools_http_handler_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/debugger/devtools_http_handler_impl.cc View 3 chunks +28 lines, -3 lines 0 comments Download
M content/public/browser/devtools_http_handler_delegate.h View 2 chunks +6 lines, -0 lines 0 comments Download
M content/shell/shell_devtools_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_devtools_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/shell_devtools_delegate_android.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pfeldman
8 years, 2 months ago (2012-09-26 12:54:30 UTC) #1
yurys
lgtm
8 years, 2 months ago (2012-09-26 13:03:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/10985041/6002
8 years, 2 months ago (2012-09-26 14:18:25 UTC) #3
commit-bot: I haz the power
Presubmit check for 10985041-6002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-09-26 14:18:29 UTC) #4
pfeldman
John, could you stamp this?
8 years, 2 months ago (2012-09-26 14:27:39 UTC) #5
jam
lgtm
8 years, 2 months ago (2012-09-26 16:24:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/10985041/6002
8 years, 2 months ago (2012-09-26 19:07:10 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 2 months ago (2012-09-26 21:45:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/10985041/6002
8 years, 2 months ago (2012-09-27 05:00:28 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-09-27 05:50:38 UTC) #10
Change committed as 158982

Powered by Google App Engine
This is Rietveld 408576698