Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/ui/gtk/zoom_bubble_gtk.cc

Issue 10985026: [gtk] Close zoom bubble immediately when window is closed to avoid orphaned (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/bubble/bubble_gtk.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/zoom_bubble_gtk.cc
diff --git a/chrome/browser/ui/gtk/zoom_bubble_gtk.cc b/chrome/browser/ui/gtk/zoom_bubble_gtk.cc
index a6362d5ee2615a441d4ed8c1efe7da873b8492f6..ba246b815b78da0c8a82088b48b2553b0a2161c7 100644
--- a/chrome/browser/ui/gtk/zoom_bubble_gtk.cc
+++ b/chrome/browser/ui/gtk/zoom_bubble_gtk.cc
@@ -48,8 +48,8 @@ void ZoomBubbleGtk::Show(GtkWidget* anchor,
// If the bubble is already showing but its |auto_close_| value is not equal
// to |auto_close|, the bubble's focus properties must change, so the
// current bubble must be closed and a new one created.
- if (g_bubble)
- g_bubble->Close();
+ Close();
+ DCHECK(!g_bubble);
g_bubble = new ZoomBubbleGtk(anchor, tab_contents, auto_close);
}
« no previous file with comments | « chrome/browser/ui/gtk/bubble/bubble_gtk.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698