Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 10985026: [gtk] Close zoom bubble immediately when window is closed to avoid orphaned (Closed)

Created:
8 years, 2 months ago by Evan Stade
Modified:
8 years, 2 months ago
Reviewers:
Kyle Horimoto, Dan Beam
CC:
chromium-reviews
Visibility:
Public.

Description

[gtk] Close zoom bubble immediately when window is closed to avoid orphaned bubbles hanging around for up to 1.5 seconds. BUG=151498 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M chrome/browser/ui/gtk/bubble/bubble_gtk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/bubble/bubble_gtk.cc View 2 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/zoom_bubble_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Evan Stade
you suggested that I should fix this bug. You will notice we almost created to ...
8 years, 2 months ago (2012-09-25 18:50:22 UTC) #1
Dan Beam
lgtm (looks great to me :D)
8 years, 2 months ago (2012-09-25 18:57:43 UTC) #2
Dan Beam
my only question is - could we get into a situation where the top level ...
8 years, 2 months ago (2012-09-25 18:59:09 UTC) #3
Kyle Horimoto
lgtm On 2012/09/25 18:59:09, Dan Beam wrote: > my only question is - could we ...
8 years, 2 months ago (2012-09-25 19:14:57 UTC) #4
Evan Stade
nope (and I actually tested that). That's actually the common case. What will happen is ...
8 years, 2 months ago (2012-09-25 19:50:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10985026/1
8 years, 2 months ago (2012-09-25 19:50:49 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-25 19:57:27 UTC) #7
Dan Beam
Goma's acting up right now :(
8 years, 2 months ago (2012-09-25 20:01:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10985026/1
8 years, 2 months ago (2012-09-25 21:03:19 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-09-25 21:52:39 UTC) #10
Change committed as 158666

Powered by Google App Engine
This is Rietveld 408576698