Issue 10985017: Turn get-own-property-descriptor.js test into a regression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10985017: Turn get-own-property-descriptor.js test into a regression (Closed)

Created:
8 years, 2 months ago by Erik Corry

Modified:
8 years, 2 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

x64 and ARM: Fix issue 2346 (order of operations in keyed store on arrays) and turn get-own-property-descriptor.js test into a regression test. Committed: https://code.google.com/p/v8/source/detail?r=12604

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+311 lines, -230 lines)			Patch
M	src/arm/ic-arm.cc	View	1 2 3	5 chunks	+152 lines, -115 lines	0 comments	Download
M	src/builtins.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1 2	7 chunks	+15 lines, -14 lines	0 comments	Download
M	src/ic.h	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 2	5 chunks	+129 lines, -100 lines	0 comments	Download
M	test/mjsunit/get-own-property-descriptor.js	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

danno

LGTM, if you omit the test case until somebody (me?) does the ARM port. https://chromiumcodereview.appspot.com/10985017/diff/4001/src/builtins.cc ...

8 years, 2 months ago (2012-09-25 12:32:03 UTC) #3

danno

LGTM, with the suggesting that you duplicate the the original test and make it a ...

8 years, 2 months ago (2012-09-25 13:21:51 UTC) #5

m.m.capewell

8 years, 2 months ago (2012-09-26 13:08:21 UTC) #6

This patch is causing failures for us with Sunspider on Cortex-A8/A9. Can you
confirm?

Expand Messages | Collapse Messages