Issue 10985007: Use either 0.1 or 1.0 versions of PPBFlashFullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10985007: Use either 0.1 or 1.0 versions of PPBFlashFullscreen. (Closed)

Created:
8 years, 3 months ago by jbauman

Modified:
8 years, 3 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use either 0.1 or 1.0 versions of PPBFlashFullscreen. This allows us to eventually remove the 0.1 version. BUG=147746 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158511

Patch Set 4 : add PP_ToBool #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -11 lines)			Patch
	M	ppapi/cpp/private/flash_fullscreen.cc	View	1 2 3	1 chunk	+27 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM with nits fixed. https://chromiumcodereview.appspot.com/10985007/diff/2001/ppapi/cpp/private/flash_fullscreen.cc File ppapi/cpp/private/flash_fullscreen.cc (right): https://chromiumcodereview.appspot.com/10985007/diff/2001/ppapi/cpp/private/flash_fullscreen.cc#newcode36 ppapi/cpp/private/flash_fullscreen.cc:36: return get_interface<PPB_FlashFullscreen_1_0>()->IsFullscreen( Nit: since this ...

8 years, 3 months ago (2012-09-24 23:06:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/10985007/7001

8 years, 3 months ago (2012-09-24 23:45:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/10985007/11001

8 years, 3 months ago (2012-09-25 00:12:57 UTC) #4

Change committed as 158511

Expand Messages | Collapse Messages

Issue 10985007: Use either 0.1 or 1.0 versions of PPBFlashFullscreen. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix indent #

Patch Set 3 : add parens #

Patch Set 4 : add PP_ToBool #

Messages