Implement redirect() API for Fetch Response

LayoutTests/http/tests/fetch/script-tests/response.js

 if (self.importScripts) {
   importScripts('../resources/fetch-test-helpers.js');
 }
 
 function consume(reader) {
   var chunks = [];
   function rec(reader) {
     return reader.read().then(function(r) {
         if (r.done) {
           return chunks;
@@ skipping 101 matching lines @@
   }, 'Response content type test');
 
 test(function() {
     [0, 1, 100, 199, 600, 700].forEach(function(status) {
         assert_throws({name: 'RangeError'},
                       function() {
                         new Response(new Blob(), {status: status});
                       },
                       'new Response with status = ' + status + ' should throw');
       });
+
+    [300, 0, 304, 305, 306, 309, 500].forEach(function(status) {
+        assert_throws({name: 'RangeError'},
+                      function() {
+                        Response.redirect('https://www.example.com/test.html',
+                                          status);
+                      },
+                      'new Response with status code (' + status +

[tyoshino (SeeGerritForStatus), 2015/04/20 04:50:00]

use the same text as L120 or update the line, too.

[shiva.jm, 2015/04/27 10:50:54]

Done. changed both line to wrap to 80 columns.

+                      ') should throw');
+      });
+
+    assert_throws(
+      {name: 'TypeError'},
+       function() {

[hiroshige, 2015/04/20 07:53:53]

-1 indent (L135, L136, L142, L143).

[shiva.jm, 2015/04/27 10:50:54]

Done.

+         Response.redirect('https://', 301);
+      },
+      'new Response with invalid URL http:// should throw');

[hiroshige, 2015/04/20 07:53:52]

The message (http://) and the test code (https://) don't match.
s/new Response/Response.redirect()/g? (here, L129, and L145).

Also, the assert message here (L138) and in L145 are the same. Could you make
these different? (to distinguish assert failures and to describe what the tests
do more precisely).

[shiva.jm, 2015/04/27 10:50:54]

Done.

+

[hiroshige, 2015/04/20 07:53:52]

Could you add a test with invalid URL and invalid status?
(i.e. a copy of L133-L138, with e.g. 300)
This is to test that redirect() checks the URL first and throws TypeError (not
RangeError) if both URL and status are invalid.

[shiva.jm, 2015/04/27 10:50:54]

Done.

+    assert_throws(
+      {name: 'TypeError'},
+       function() {
+         Response.redirect('https://');
+      },
+      'new Response with invalid URL http:// should throw');

[hiroshige, 2015/04/20 07:53:53]

Could you add tests of invalid URLs that contains \x00, \x0a, or \x0d?
I think URL parser https://url.spec.whatwg.org/#concept-url-parser returns
failure for such URLs but not sure...but anyway we have to reject such URLs to
avoid to set a Location header with invalid characters.

[shiva.jm, 2015/04/27 10:50:54]

Done.

+
     [200, 300, 400, 500, 599].forEach(function(status) {
         var response = new Response(new Blob(), {status: status});
         assert_equals(response.status, status, 'Response.status should match');
         if (200 <= status && status <= 299)
           assert_true(response.ok, 'Response.ok must be true for ' + status);
         else
           assert_false(response.ok, 'Response.ok must be false for ' + status);
       });
 
     INVALID_HEADER_NAMES.forEach(function(name) {
@@ skipping 286 matching lines @@
       }).then(function(texts) {
         assert_equals(texts[0], '');
         assert_equals(texts[1], '');
         return res.body.getReader().read();
       }).then(function(r) {
         assert_true(r.done);
         assert_equals(r.value, undefined);
       });
   }, 'Read after text()');
 
+promise_test(function() {
+    var response = Response.redirect('https://www.example.com/test.html');
+    return response.text().then(function(text) {
+        assert_equals(response.status, 302,
+                      'default value of status is always 302');
+        assert_equals(response.headers.get('location'),
+                      'https://www.example.com/test.html',
+                      'Location header should be correct absoulte URL');

[hiroshige, 2015/04/20 07:53:53]

Could you add assertion that response.headers has only one header?

[shiva.jm, 2015/04/27 10:50:54]

Done.

[hiroshige, 2015/04/27 11:47:25]

Not added? e.g.
        assert_equals(size(response.headers), 1,
                      'Respons.redirect().headers must contain ' +
                      'a Location header only');

+      });
+  }, 'Response.redirect() with default value');
+
+promise_test(function() {
+    var response = Response.redirect('https://www.example.com/test.html',
+                                     301);
+    return response.text().then(function(text) {
+        assert_equals(response.status, 301,
+                      'value of status is 301');
+        assert_equals(response.headers.get('location'),
+                      'https://www.example.com/test.html',
+                      'Location header should be correct absoulte URL');
+      });
+  }, 'Response.redirect()');

[hiroshige, 2015/04/20 07:53:52]

optional: How about 'Response.redirect() with 301'?

[shiva.jm, 2015/04/27 10:50:54]

Done.

+
 done();