Issue 10984065: Add the VFP-ness to the minor number of the keyed store elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10984065: Add the VFP-ness to the minor number of the keyed store elements (Closed)

Created:
8 years, 2 months ago by Erik Corry

Modified:
8 years, 2 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Add the VFP-ness to the minor number of the keyed store elements IC so that the version from the snapshot is not used if we have a more capable CPU at runtime. Committed: https://code.google.com/p/v8/source/detail?r=12624

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -5 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View	1	4 chunks	+16 lines, -4 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/ic.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

8 years, 2 months ago (2012-09-27 09:44:37 UTC) #2

LGTM, is possible to write a test that checks that we are actually using the
correct stub?

Expand Messages | Collapse Messages