Fix Gmail Checker to update on reference fragment navigations, so the unread

Fix Gmail Checker to update on reference fragment navigations, so the unread
count changes as users navigate within gmail.

BUG=152220
TBR=aa@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158703

[commit-bot: I haz the power, 2012-09-25 21:23:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10984030/1

[Aaron Boodman, 2012-09-25 21:38:14]

http://codereview.chromium.org/10984030/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/examples/extensions/gmail/background.js
(right):

http://codereview.chromium.org/10984030/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:335:
chrome.webNavigation.onReferenceFragmentUpdated.addListener(
This doesn't exist on Chrome 21, so it's going to throw here. You need to
feature detect it.

It would be good to fall back to tabs.onUpdated in that case.

[Matt Perry, 2012-09-25 21:57:40]

http://codereview.chromium.org/10984030/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/examples/extensions/gmail/background.js
(right):

http://codereview.chromium.org/10984030/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:335:
chrome.webNavigation.onReferenceFragmentUpdated.addListener(
On 2012/09/25 21:38:14, Aaron Boodman wrote:
> This doesn't exist on Chrome 21, so it's going to throw here. You need to
> feature detect it.
> 
> It would be good to fall back to tabs.onUpdated in that case.

It exists, even on stable:
http://developer.chrome.com/stable/extensions/webNavigation.html#event-onRefe...

[Matt Perry, 2012-09-25 22:09:08]

http://codereview.chromium.org/10984030/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/examples/extensions/gmail/background.js
(right):

http://codereview.chromium.org/10984030/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:335:
chrome.webNavigation.onReferenceFragmentUpdated.addListener(
On 2012/09/25 21:57:40, Matt Perry wrote:
> On 2012/09/25 21:38:14, Aaron Boodman wrote:
> > This doesn't exist on Chrome 21, so it's going to throw here. You need to
> > feature detect it.
> > 
> > It would be good to fall back to tabs.onUpdated in that case.
> 
> It exists, even on stable:
>
http://developer.chrome.com/stable/extensions/webNavigation.html#event-onRefe...

I added a feature detect anyway, just to be paranoid.

[commit-bot: I haz the power, 2012-09-25 22:14:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10984030/4002

[commit-bot: I haz the power, 2012-09-26 00:15:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10984030/4002

[Aaron Boodman, 2012-09-26 00:18:50]

Hm, you are right. Nevertheless, it's nice to support even older versions, so
thanks for feature-detecing.

[commit-bot: I haz the power, 2012-09-26 00:35:42]

Change committed as 158703