Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 10984009: Allow immutable textures into mailboxes (Closed)

Created:
8 years, 3 months ago by piman
Modified:
8 years, 3 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Allow immutable textures into mailboxes BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158496

Patch Set 1 #

Total comments: 4

Patch Set 2 : address review comments #

Total comments: 2

Patch Set 3 : doh #

Patch Set 4 : doh #

Patch Set 5 : fix clang #

Patch Set 6 : fix spec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_texture_mailbox.txt View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/texture_definition.h View 1 2 3 4 4 chunks +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
piman
8 years, 3 months ago (2012-09-24 22:46:34 UTC) #1
apatrick_chromium
https://codereview.chromium.org/10984009/diff/1/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/10984009/diff/1/gpu/command_buffer/service/texture_manager.cc#newcode882 gpu/command_buffer/service/texture_manager.cc:882: SetLevelInfo(info, Should a immutable texture object that has been ...
8 years, 3 months ago (2012-09-24 22:55:16 UTC) #2
piman
https://codereview.chromium.org/10984009/diff/1/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/10984009/diff/1/gpu/command_buffer/service/texture_manager.cc#newcode882 gpu/command_buffer/service/texture_manager.cc:882: SetLevelInfo(info, On 2012/09/24 22:55:16, apatrick_chromium wrote: > Should a ...
8 years, 3 months ago (2012-09-24 22:59:50 UTC) #3
apatrick_chromium
https://codereview.chromium.org/10984009/diff/4001/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/10984009/diff/4001/gpu/command_buffer/service/texture_manager.cc#newcode905 gpu/command_buffer/service/texture_manager.cc:905: info->IsImmutable(), Need to call IsImmutable before SetImmutable.
8 years, 3 months ago (2012-09-24 23:00:51 UTC) #4
piman
https://codereview.chromium.org/10984009/diff/4001/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/10984009/diff/4001/gpu/command_buffer/service/texture_manager.cc#newcode905 gpu/command_buffer/service/texture_manager.cc:905: info->IsImmutable(), On 2012/09/24 23:00:51, apatrick_chromium wrote: > Need to ...
8 years, 3 months ago (2012-09-24 23:03:36 UTC) #5
apatrick_chromium
lgtm
8 years, 3 months ago (2012-09-24 23:04:22 UTC) #6
apatrick_chromium
Oh and can you update the spec as well?
8 years, 3 months ago (2012-09-24 23:05:34 UTC) #7
piman
On 2012/09/24 23:05:34, apatrick_chromium wrote: > Oh and can you update the spec as well? ...
8 years, 3 months ago (2012-09-24 23:11:39 UTC) #8
apatrick_chromium
LGTM. thx.
8 years, 3 months ago (2012-09-24 23:12:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10984009/11003
8 years, 3 months ago (2012-09-24 23:16:22 UTC) #10
commit-bot: I haz the power
8 years, 3 months ago (2012-09-25 02:04:35 UTC) #11
Change committed as 158496

Powered by Google App Engine
This is Rietveld 408576698