Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/browser/ui/hung_plugin_tab_helper.cc

Issue 10983028: Render/pepper hang debugging: generate dumps for the browser and renderer processes if users kill a… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/hang_monitor/hang_crash_dump_win.cc ('k') | ppapi/host/ppapi_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/hung_plugin_tab_helper.cc
diff --git a/chrome/browser/ui/hung_plugin_tab_helper.cc b/chrome/browser/ui/hung_plugin_tab_helper.cc
index 6e6f96e6fbb35f3da60ded1191d1ff717ab6b7de..fcbcccf6f0d2618167dfb1ca65c407f80bf84ed8 100644
--- a/chrome/browser/ui/hung_plugin_tab_helper.cc
+++ b/chrome/browser/ui/hung_plugin_tab_helper.cc
@@ -65,11 +65,15 @@ class OwnedHandleVector {
DISALLOW_COPY_AND_ASSIGN(OwnedHandleVector);
};
+void DumpBrowserInBlockingPool() {
+ CrashDumpForHangDebugging(::GetCurrentProcess());
+}
+
void DumpRenderersInBlockingPool(OwnedHandleVector* renderer_handles) {
for (std::vector<HANDLE>::const_iterator iter =
renderer_handles->data().begin();
iter != renderer_handles->data().end(); ++iter) {
- CrashDumpIfProcessHandlingPepper(*iter);
+ CrashDumpForHangDebugging(*iter);
}
}
@@ -314,7 +318,10 @@ void HungPluginTabHelper::KillPlugin(int child_id) {
// due to our crash dump uploading restrictions. So we just don't generate
// renderer crash dumps in that case.
if (renderer_handles->data().size() > 0 &&
- renderer_handles->data().size() < 8) {
+ renderer_handles->data().size() < 4) {
+ content::BrowserThread::PostBlockingPoolSequencedTask(
+ kDumpChildProcessesSequenceName, FROM_HERE,
+ base::Bind(&DumpBrowserInBlockingPool));
content::BrowserThread::PostBlockingPoolSequencedTask(
kDumpChildProcessesSequenceName, FROM_HERE,
base::Bind(&DumpRenderersInBlockingPool,
« no previous file with comments | « chrome/browser/hang_monitor/hang_crash_dump_win.cc ('k') | ppapi/host/ppapi_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698