Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 10983023: Port certificate verification to iOS. (Closed)

Created:
8 years, 2 months ago by droger
Modified:
8 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, stuartmorgan
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Port certificate verification to iOS. Certificate verification relies on NSS implementation on iOS. BUG=145954 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158787

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -27 lines) Patch
M net/base/cert_verify_proc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/cert_verify_proc_nss.cc View 9 chunks +36 lines, -6 lines 0 comments Download
M net/base/cert_verify_proc_unittest.cc View 1 11 chunks +11 lines, -11 lines 0 comments Download
M net/base/ev_root_ca_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/multi_threaded_cert_verifier.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/net_test_suite.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M net/base/x509_util_ios.h View 1 3 chunks +29 lines, -1 line 0 comments Download
M net/base/x509_util_ios.cc View 1 2 3 chunks +61 lines, -1 line 0 comments Download
M net/net.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
droger
8 years, 2 months ago (2012-09-25 16:17:31 UTC) #1
Ryan Sleevi
This is just upstreaming, right? I wasn't sure if there was new code here or ...
8 years, 2 months ago (2012-09-25 17:13:33 UTC) #2
droger
On 2012/09/25 17:13:33, Ryan Sleevi wrote: > This is just upstreaming, right? I wasn't sure ...
8 years, 2 months ago (2012-09-26 09:13:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/10983023/2003
8 years, 2 months ago (2012-09-26 09:13:54 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 11:51:22 UTC) #5
Change committed as 158787

Powered by Google App Engine
This is Rietveld 408576698