FontScaleFactor and ForceEnableZoom pref_names.

FontScaleFactor and ForceEnableZoom pref_names.

Adding prefs::kWebKitFontScaleFactor and prefs::kWebKitForceEnableZoom to the
pref_names. It will be used by font boosting on Android.

BUG=151216
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158664

[aurimas (slooooooooow), 2012-09-24 22:03:36]

Hey Nico,

Could you take a look at this CL?

Thanks,
Aurimas

[Nico, 2012-09-24 22:51:34]

lgtm

[Nico, 2012-09-24 22:56:35]

(Do you need to add a call to prefs->RegisterBooleanPref() somewhere?)

[aurimas (slooooooooow), 2012-09-24 23:16:40]

On 2012/09/24 22:56:35, Nico wrote:
> (Do you need to add a call to prefs->RegisterBooleanPref() somewhere?)

Good catch. Thanks! Fixed!

[commit-bot: I haz the power, 2012-09-25 00:12:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/10983010/5002

[aurimas (slooooooooow), 2012-09-25 01:06:01]

Hey Adam,

I'm upstreaming some prefs and I found your TODO in
webkit/glue/webpreferences.cc saying:
"Rename force_enable_zoom to match setIgnoreViewportTagMaximumScale."

What should I rename force_enable_zoom to? ignore_viewport_tag_maximum_scale?

Aurimas

[abarth-chromium, 2012-09-25 02:27:29]

Probably.  The value maps to this WebKit API:

http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/public/WebView.h#...

Adam


On Mon, Sep 24, 2012 at 6:06 PM,  <aurimas@chromium.org> wrote:
> Hey Adam,
>
> I'm upstreaming some prefs and I found your TODO in
> webkit/glue/webpreferences.cc saying:
> "Rename force_enable_zoom to match setIgnoreViewportTagMaximumScale."
>
> What should I rename force_enable_zoom to?
> ignore_viewport_tag_maximum_scale?
>
> Aurimas
>
> https://codereview.chromium.org/10983010/

[aurimas (slooooooooow), 2012-09-25 16:36:23]

Hello James,

Could you take a look at this CL as I am changing webkit/?

Aurimas

[jamesr, 2012-09-25 17:25:31]

webkit/ lgtm

[commit-bot: I haz the power, 2012-09-25 17:32:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/10983010/2004

[commit-bot: I haz the power, 2012-09-25 20:19:28]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-25 20:33:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/10983010/2004

[commit-bot: I haz the power, 2012-09-25 21:48:43]

Change committed as 158664