Reland - cros: Add CHECK for screen unlock problem

Reland - cros: Add CHECK for screen unlock problem

On some devices when you unlock the screen after suspend the launcher and
desktop windows do not appear. I suspect the background widget is not being
reparented properly but I cannot reproduce the problem internally.  Since
the user can't recover from this state without rebooting, add some CHECKs
to try to track down the source.

Also initialize empty wallpaper if we're running tests, as we previously
skipped it which would cause my CHECKs to be hit.

BUG=149043
TEST=ScreenLockerTest and manual, lock screen with Ctrl-Shift-L, unlock by entering password


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158846

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=159154

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159636

[James Cook, 2012-09-25 21:47:33]

Nikita & Biao, PTAL.  I'm trying to track down a problem related to screen
unlock, so this just adds some CHECKs. I did have to add empty wallpaper so
interactive_ui_tests would pass - apparently we weren't creating any wallpaper
before so the window property kComponentWrapper wouldn't exist for any root
window.

[bshe, 2012-09-25 22:04:50]

lgtm

On 2012/09/25 21:47:33, James Cook (Chromium) wrote:
> Nikita & Biao, PTAL.  I'm trying to track down a problem related to screen
> unlock, so this just adds some CHECKs. I did have to add empty wallpaper so
> interactive_ui_tests would pass - apparently we weren't creating any wallpaper
> before so the window property kComponentWrapper wouldn't exist for any root
> window.

[Nikita (slow), 2012-09-26 12:23:53]

lgtm

+Denis, who originally wrote this code

[James Cook, 2012-09-26 15:28:10]

On 2012/09/26 12:23:53, Nikita Kostylev wrote:
> lgtm
> 
> +Denis, who originally wrote this code

I'm going to commit this based on two LGTMs - Denis, please let me know if I
should revert.

[commit-bot: I haz the power, 2012-09-26 15:33:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/10982035/2001

[commit-bot: I haz the power, 2012-09-26 19:10:10]

Change committed as 158846

[James Cook, 2012-09-28 00:03:53]

On 2012/09/26 19:10:10, I haz the power (commit-bot) wrote:
> Change committed as 158846

Reverted as this caused PFQ failures due to a recent change in LoginWizard. 
I'll add CHECKs that are more specific to ScreenLocker.

[James Cook, 2012-10-01 17:27:29]

Biao, can you take another look at this?  I've moved the CHECK to only trigger
if screen unlock fails to move the background.

[bshe, 2012-10-01 18:02:11]

On 2012/10/01 17:27:29, James Cook (Chromium) wrote:
> Biao, can you take another look at this?  I've moved the CHECK to only trigger
> if screen unlock fails to move the background.

lgtm. You probably need Nikita's review and owner approval though.

[James Cook, 2012-10-01 18:27:04]

Nikita, can I get OWNERs approval?  This is a reland.

[Nikita (slow), 2012-10-01 20:43:48]

lgtm

[commit-bot: I haz the power, 2012-10-02 00:21:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/10982035/11001

[commit-bot: I haz the power, 2012-10-02 03:25:33]

Change committed as 159636