Issue 10982031: Fix build warnings in NaCl IPC proxy.

Issue 10982031: Fix build warnings in NaCl IPC proxy. (Closed)

Created:
8 years, 2 months ago by bbudge

Modified:
8 years, 2 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix build warnings in NaCl IPC proxy. BUG=116317 TEST=builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159344

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -15 lines)			Patch
M	ipc/ipc.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ipc/ipc_channel.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ipc/ipc_channel.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ipc/ipc_channel_nacl.cc	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download

Total messages: 9 (0 generated)

nfullagar

Looks like there is a merge conflict on the try bots - failing the patch ...

8 years, 2 months ago (2012-09-25 18:37:12 UTC) #2

bbudge

Looks like someone beat me to part of this. Removing some unneeded code that strands ...

8 years, 2 months ago (2012-09-26 00:07:55 UTC) #3

bbudge

This is still worth doing to remove an unreferenced global and some unneeded IPC channel ...

8 years, 2 months ago (2012-09-27 12:08:20 UTC) #4

bbudge

Looking for OWNERS review. This only affects NaCl untrusted build, and removes some unneeded code. ...

8 years, 2 months ago (2012-09-28 18:02:42 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/10982031/8003

8 years, 2 months ago (2012-09-28 19:19:36 UTC) #8

Change committed as 159344