UMA counts for corrupt cache db.

UMA counts for corrupt cache db.

BUG=152263
TEST=manual.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158720

[achuithb, 2012-09-25 22:30:50]

Please review. Thank you!

[satorux1, 2012-09-25 22:40:50]

http://codereview.chromium.org/10981030/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/drive_cache_metadata.cc (right):

http://codereview.chromium.org/10981030/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/drive_cache_metadata.cc:472:
UMA_HISTOGRAM_COUNTS("Drive.CorruptCacheDB", 1);
I think we want to know success/failure ratio and failure reasons, so we want to
do something like:

enum {
  LOAD_SUCCESS,
  LOAD_FAILURE_CORRUPT_DB,
  LOAD_FAILURE_OTHER,
  LOAD_MAX_VALUE,
};

Then do:

UMA_HISTOGRAM_ENUMERATION("Drive.CacheMetadataLoading", LOAD_SUCCESS,
LOAD_MAX_VALUE)

I think we want to distinguish corruption from other errors, so I'd suggest
doing:

if (!db_status.ok()) {
  if (db_status.IsCorruption()) {
    LOG(WARNING) << "Detected corrupt db";
    UMA_HISTOGRAM_ENUMERATION("Drive.CacheMetadataLoading",
LOAD_FAILURE_CORRUPT_DB, LOAD_MAX_VALUE);
  } else {
    LOG(WARNING)  << "Failed to open db for unknown reason";
    UMA_HISTOGRAM_ENUMERATION("Drive.CacheMetadataLoading", LOAD_FAILURE_OTHER,
LOAD_MAX_VALUE);
  }

[achuithb, 2012-09-25 23:03:59]

PTAL.

[satorux1, 2012-09-25 23:09:03]

LGTM! Cleaner than my suggestion. :)

http://codereview.chromium.org/10981030/diff/3003/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/drive_cache_metadata.cc (right):

http://codereview.chromium.org/10981030/diff/3003/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/drive_cache_metadata.cc:479: LOG(WARNING) <<
"Cache db failed to open: " << db_status.ToString();
ToString() is neat!

[achuithb, 2012-09-25 23:12:14]

On 2012/09/25 23:09:03, satorux1 wrote:
> LGTM! Cleaner than my suggestion. :)

Thank you!

>
http://codereview.chromium.org/10981030/diff/3003/chrome/browser/chromeos/gda...
> File chrome/browser/chromeos/gdata/drive_cache_metadata.cc (right):
> 
>
http://codereview.chromium.org/10981030/diff/3003/chrome/browser/chromeos/gda...
> chrome/browser/chromeos/gdata/drive_cache_metadata.cc:479: LOG(WARNING) <<
> "Cache db failed to open: " << db_status.ToString();
> ToString() is neat!

[commit-bot: I haz the power, 2012-09-25 23:12:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/10981030/3

[commit-bot: I haz the power, 2012-09-26 00:14:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/10981030/3

[commit-bot: I haz the power, 2012-09-26 02:05:54]

Change committed as 158720