[Android] Exclude unsupported URLs from chrome://chrome-urls.

[Android] Exclude unsupported URLs from chrome://chrome-urls.

BUG=136996
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158555

[newt (away), 2012-09-25 00:47:20]

PTAL, thanks!

[Nico, 2012-09-25 01:56:29]

(+msw to comment on if the alphabetical order is intentional. If so, the cros
entries should be sorted too I suppose)

http://codereview.chromium.org/10980008/diff/1/chrome/browser/browser_about_h...
File chrome/browser/browser_about_handler.cc (left):

http://codereview.chromium.org/10980008/diff/1/chrome/browser/browser_about_h...
chrome/browser/browser_about_handler.cc:25: chrome::kChromeUIBookmarksHost,
I believe about:about lists urls in the order they are in in this array, and the
intent is to have them sorted alphabetically. Can you keep them in the current
order?

http://codereview.chromium.org/10980008/diff/1/chrome/browser/browser_about_h...
File chrome/browser/browser_about_handler.cc (right):

http://codereview.chromium.org/10980008/diff/1/chrome/browser/browser_about_h...
chrome/browser/browser_about_handler.cc:51: // TODO(satish): Enable after
http://crbug.com/143146 is fixed.
nit: Do you think having TODOs on satish is useful?

[msw, 2012-09-25 02:23:05]

http://codereview.chromium.org/10980008/diff/1/chrome/browser/browser_about_h...
File chrome/browser/browser_about_handler.cc (left):

http://codereview.chromium.org/10980008/diff/1/chrome/browser/browser_about_h...
chrome/browser/browser_about_handler.cc:25: chrome::kChromeUIBookmarksHost,
On 2012/09/25 01:56:29, Nico wrote:
> I believe about:about lists urls in the order they are in in this array, and
the
> intent is to have them sorted alphabetically. Can you keep them in the current
> order?

The ordering seems fine. These identifiers are sorted so devs can more easily
update the list; putting preprocessor blocks at the end and sorting within each
block seems to be the norm.

The path strings themselves (which may not match their identifiers) should be
sorted separately in ChromePaths() or elsewhere so users get a sorted list of
links. I'll address that tangential issue in a separate CL.

[msw, 2012-09-25 02:28:30]

In other words; LGTM (with Nico's pending approval).

[Nico, 2012-09-25 02:30:52]

lgtm

[commit-bot: I haz the power, 2012-09-25 02:31:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/10980008/1

[newt (away), 2012-09-25 02:36:57]

http://codereview.chromium.org/10980008/diff/1/chrome/browser/browser_about_h...
File chrome/browser/browser_about_handler.cc (right):

http://codereview.chromium.org/10980008/diff/1/chrome/browser/browser_about_h...
chrome/browser/browser_about_handler.cc:51: // TODO(satish): Enable after
http://crbug.com/143146 is fixed.
On 2012/09/25 01:56:29, Nico wrote:
> nit: Do you think having TODOs on satish is useful?

Fair point.  In fact, the bug's been reassigned to dfalcantara.

[commit-bot: I haz the power, 2012-09-25 04:13:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/newt@chromium.org/10980008/11001

[commit-bot: I haz the power, 2012-09-25 13:06:08]

Change committed as 158555