Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10979027: Add test APK information to buildbot step for Android instrumentation tests. (Closed)

Created:
8 years, 2 months ago by klundberg
Modified:
8 years, 2 months ago
Reviewers:
bulach, Yaron, Isaac (away)
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Add test APK information to buildbot step for Android instrumentation tests. Since we will run instrumentation tests for multiple test APKs, this adds the test APK name to the name of the buildbot step. Without this change, we will have multiple buildbot steps with the same name although they are running tests for different APKS. And as a result, the stdio will end up pointing to the same content for each of these steps. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/android/run_instrumentation_tests.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
klundberg
Ping?
8 years, 2 months ago (2012-09-26 17:59:01 UTC) #1
Yaron
lgtm Fyi, in chromium, upstreaming a patch doesn't send a mail. You have to Public+Mail ...
8 years, 2 months ago (2012-09-27 04:48:11 UTC) #2
Isaac (away)
lgtm
8 years, 2 months ago (2012-09-27 04:59:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/klundberg@chromium.org/10979027/1
8 years, 2 months ago (2012-09-27 16:43:06 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-09-27 20:07:22 UTC) #5
Change committed as 159099

Powered by Google App Engine
This is Rietveld 408576698