Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 10979023: Fix bug 152277: [Panels] Panels are still showing taskbar icons in smaller resolution on Windows (Closed)

Created:
8 years, 2 months ago by jianli
Modified:
8 years, 2 months ago
Reviewers:
jennb
CC:
chromium-reviews, Dmitry Titov, dcheng
Visibility:
Public.

Description

Fix bug 152277: [Panels] Panels are still showing taskbar icons in smaller resolution on Windows The test is added at http://codereview.chromium.org/10987037/ that contains all the test cases for more than this bug. We want to separate out the fix and the remaining complicated test such that we could merge the fix to the branch if needed. BUG=152277 TEST=Test will be added in next patch Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/panels/panel.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jianli
8 years, 2 months ago (2012-09-25 21:36:43 UTC) #1
jennb
Can the test be combined into this patch?
8 years, 2 months ago (2012-09-25 22:45:31 UTC) #2
jennb
Can the test be combined into this patch?
8 years, 2 months ago (2012-09-25 22:45:55 UTC) #3
jianli
On 2012/09/25 22:45:55, jennb wrote: > Can the test be combined into this patch? I ...
8 years, 2 months ago (2012-09-25 22:55:45 UTC) #4
jennb
On 2012/09/25 22:55:45, jianli wrote: > On 2012/09/25 22:45:55, jennb wrote: > > Can the ...
8 years, 2 months ago (2012-09-25 23:02:08 UTC) #5
jianli
On 2012/09/25 23:02:08, jennb wrote: > On 2012/09/25 22:55:45, jianli wrote: > > On 2012/09/25 ...
8 years, 2 months ago (2012-09-25 23:33:34 UTC) #6
jennb
lgtm
8 years, 2 months ago (2012-09-25 23:37:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/10979023/1
8 years, 2 months ago (2012-09-26 00:36:02 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 03:46:00 UTC) #9
Change committed as 158739

Powered by Google App Engine
This is Rietveld 408576698