Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 10979020: Revert r155813 "Reland - cros: Add chat icon to app list" (Closed)

Created:
8 years, 2 months ago by xiyuan
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, tfarina, stevenjb
Visibility:
Public.

Description

Revert r155813 "Reland - cros: Add chat icon to app list" r155813 turns out to be no longer needed and causing failures with ntp ordering change. BUG=152237, 149750 TEST=Verify no DCHECK failure or crash when showing app list with gtalk extension installed and gtalk extension does not show in app list. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158760

Patch Set 1 #

Patch Set 2 : not showing talk extension instead of fixing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -81 lines) Patch
M chrome/browser/ui/app_list/apps_model_builder.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_item.cc View 1 4 chunks +21 lines, -48 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
xiyuan
Putting the fix in ExtensionAppItem where we already have special case for talk extension since ...
8 years, 2 months ago (2012-09-25 20:48:00 UTC) #1
xiyuan
Ignore this. Checked with Josh and we could clean up the hacks now. Will update ...
8 years, 2 months ago (2012-09-25 21:19:15 UTC) #2
xiyuan
CL is updated to remove the talk extension hack that is no longer needed. Please ...
8 years, 2 months ago (2012-09-25 22:46:37 UTC) #3
asargent_no_longer_on_chrome
chrome/common/extensions/* LGTM
8 years, 2 months ago (2012-09-25 22:59:59 UTC) #4
sky
LGTM
8 years, 2 months ago (2012-09-25 23:40:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10979020/2002
8 years, 2 months ago (2012-09-26 00:59:00 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 06:56:38 UTC) #7
Change committed as 158760

Powered by Google App Engine
This is Rietveld 408576698