Issue 10979019: [gtk] fix zoom bubble showing up on wrong window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10979019: [gtk] fix zoom bubble showing up on wrong window (Closed)

Created:
8 years, 2 months ago by Evan Stade

Modified:
8 years, 2 months ago

Reviewers:
Kyle Horimoto, jam, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[gtk] fix zoom bubble showing up on wrong window ... most of the time. Since IsActive doesn't work, it still can show the bubble on the wrong window if two windows both show the same host. BUG=152229 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158806

Patch Set 1 #

Patch Set 2 : updatecomment #

Patch Set 3 : sync #

Patch Set 4 : . #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -20 lines)			Patch
M	chrome/browser/ui/zoom/zoom_controller.h	View	1 2	1 chunk	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/zoom/zoom_controller.cc	View	1 2 3	4 chunks	+20 lines, -11 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/web_contents.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10979019/13002

8 years, 2 months ago (2012-09-26 13:44:09 UTC) #5

Change committed as 158806

Expand Messages | Collapse Messages