Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 10979017: OOBE factory reset screen makes reboot if requested after sign in. (Closed)

Created:
8 years, 2 months ago by glotov
Modified:
8 years, 2 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

OOBE factory reset screen makes reboot if requested after sign in. This is because StartDeviceWipe() will not work after user sign in and sign out (without reboot). This is done so for security reasons. BUG=122768 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 3 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
glotov
Hi!
8 years, 2 months ago (2012-09-25 14:25:43 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 2 months ago (2012-09-25 15:19:18 UTC) #2
Nikita (slow)
lgtm
8 years, 2 months ago (2012-09-25 15:19:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glotov@chromium.org/10979017/1
8 years, 2 months ago (2012-09-25 15:20:47 UTC) #4
Nikita (slow)
Please use cros_* bots fro Chrome OS changes next time lgtm
8 years, 2 months ago (2012-09-25 15:21:14 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-09-25 17:44:24 UTC) #6
Change committed as 158603

Powered by Google App Engine
This is Rietveld 408576698