Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 10978037: [OSX] Pass --enable-sandbox-logging to more sub-processes. (Closed)

Created:
8 years, 2 months ago by Scott Hess - ex-Googler
Modified:
8 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, native-client-reviews_googlegroups.com, jam
Visibility:
Public.

Description

[OSX] Pass --enable-sandbox-logging to more sub-processes. This makes it easier to debug what is being blocked by the sandbox. gpu and renderer processes were already covered, this adds propagation for utility and worker processes, and nacl, pepper and npapi plugin processes. The points to handle were discovered by looking for kNoSandbox cases, which is why NPAPI is on the list, even though we do not sandbox it on OSX at this time. BUG=152327 TEST=--enable-sandbox-logging and look for messages from subprocesses in /var/log/syslog.log Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M chrome/common/nacl_cmd_line.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Scott Hess - ex-Googler
Your comment on the flapper thing made me try harder, and this was the result. ...
8 years, 2 months ago (2012-09-25 23:26:35 UTC) #1
jeremy
LGTM, thank you very very much for taking the time to fix this!
8 years, 2 months ago (2012-09-27 21:29:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10978037/1
8 years, 2 months ago (2012-10-02 20:00:50 UTC) #3
commit-bot: I haz the power
Presubmit check for 10978037-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-02 20:00:54 UTC) #4
Scott Hess - ex-Googler
For new OWNERS, this change should only impact people debugging sandbox issues on OSX. On ...
8 years, 2 months ago (2012-10-02 20:03:34 UTC) #5
sky
LGTM
8 years, 2 months ago (2012-10-02 20:10:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10978037/1
8 years, 2 months ago (2012-10-03 17:42:19 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-03 19:55:17 UTC) #8
Change committed as 159956

Powered by Google App Engine
This is Rietveld 408576698