Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 10978036: Sync the SafeBrowsing csd.proto file with the latest server-side version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unused comment. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index bb6b75f340dd37f4253f1a334c8b56e815c784bf..e139b32b62ee59fa16689ec09f9d2a60c710e510 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -17,7 +17,7 @@ package safe_browsing;
message ClientPhishingRequest {
// URL that the client visited. The CGI parameters are stripped by the
- // client. This field is ONLY set for UMA-enabled users.
+ // client.
optional string url = 1;
// A 5-byte SHA-256 hash prefix of the URL. Before hashing the URL is
@@ -66,6 +66,8 @@ message ClientPhishingRequest {
// where the referrer uses HTTPs.
// OBSOLETE: Use feature 'Referrer=<referrer>' instead.
optional string OBSOLETE_referrer_url = 9;
+
+ // Field 11 is only used on the server.
}
message ClientPhishingResponse {
@@ -138,6 +140,7 @@ message ClientDownloadRequest {
message Element {
// DER-encoded X.509 representation of the certificate.
optional bytes certificate = 1;
+ // Fields 2 - 7 are only used on the server.
}
repeated Element element = 1;
}
@@ -158,6 +161,8 @@ message ClientDownloadRequest {
// True if the download was user initiated.
optional bool user_initiated = 6;
+ // Fields 7 and 8 are only used on the server.
+
// Name of the file where the download would be stored if the
// download completes. E.g., "bla.exe".
optional string file_basename = 9;
@@ -175,6 +180,8 @@ message ClientDownloadRequest {
// Locale of the device, eg en, en_US.
optional string locale = 11;
+
+ // Field 12 is only used on the server.
}
message ClientDownloadResponse {
@@ -200,4 +207,38 @@ message ClientDownloadResponse {
optional string url = 2;
}
optional MoreInfo more_info = 2;
+
+ // An arbitrary token that should be sent along for further server requests.
+ optional bytes token = 3;
+}
+
+// The following protocol buffer holds the feedback report gathered
+// from the user regarding the download.
+message ClientDownloadReport {
+ // The information of user who provided the feedback.
+ // This is going to be useful for handling appeals.
+ message UserInformation {
+ optional string email = 1;
+ }
+
+ enum Reason {
+ SHARE = 0;
+ FALSE_POSITIVE = 1;
+ APPEAL = 2;
+ }
+
+ // The type of feedback for this report.
+ optional Reason reason = 1;
+
+ // The original download ping
+ optional ClientDownloadRequest download_request = 2;
+
+ // Stores the information of the user who provided the feedback.
+ optional UserInformation user_information = 3;
+
+ // Unstructed comments provided by the user.
+ optional bytes comment = 4;
+
+ // The original download response sent from the verdict server.
+ optional ClientDownloadResponse download_response = 5;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698