Add support in iossim for simulating retina devices

Add support in iossim for simulating retina devices

This CL sets device name in <simulator_home>/Library/Preferences/com.apple.iphonesimulator.plist, which allows the caller to specify any string in the iOS Simulator's Hardware -> Device menu (e.g. iPhone (Retina 3.5-inch)), instead of just iPhone or iPad.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160427

[lliabraa, 2012-09-25 18:05:29]

tvl for review
rohitrao for review + OWNERS

[TVL, 2012-09-25 19:13:23]

lgtm

https://codereview.chromium.org/10978027/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://codereview.chromium.org/10978027/diff/1/testing/iossim/iossim.mm#newc...
testing/iossim/iossim.mm:480: NSMutableDictionary* plistDict =
might be worth a comment here that the simulator has to not be running for this
to get picked up correctly.  For now i'd say let the wrapping scripts kill the
simulator rather than adding that here.

[lliabraa, 2012-10-04 15:51:39]

The script that calls this on the bot is sending 'iphone' by default so I've
made the -d parameter case insensitive so it will continue to work.

https://chromiumcodereview.appspot.com/10978027/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/10978027/diff/1/testing/iossim/iossim....
testing/iossim/iossim.mm:480: NSMutableDictionary* plistDict =
On 2012/09/25 19:13:23, TVL wrote:
> might be worth a comment here that the simulator has to not be running for
this
> to get picked up correctly.  For now i'd say let the wrapping scripts kill the
> simulator rather than adding that here.

Done.

[TVL, 2012-10-04 16:00:48]

lgtm

https://chromiumcodereview.appspot.com/10978027/diff/12001/testing/iossim/ios...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/10978027/diff/12001/testing/iossim/ios...
testing/iossim/iossim.mm:509: return range.location != NSNotFound;
return range.location == 0;

can't hurt.

[rohitrao (ping after 24h), 2012-10-05 12:18:34]

lgtm

https://chromiumcodereview.appspot.com/10978027/diff/12001/testing/iossim/ios...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/10978027/diff/12001/testing/iossim/ios...
testing/iossim/iossim.mm:661: deviceName);
Here I would indent more to line up with the parens.

[lliabraa, 2012-10-05 13:08:59]

https://chromiumcodereview.appspot.com/10978027/diff/12001/testing/iossim/ios...
File testing/iossim/iossim.mm (right):

https://chromiumcodereview.appspot.com/10978027/diff/12001/testing/iossim/ios...
testing/iossim/iossim.mm:509: return range.location != NSNotFound;
On 2012/10/04 16:00:48, TVL wrote:
> return range.location == 0;
> 
> can't hurt.

Done.

https://chromiumcodereview.appspot.com/10978027/diff/12001/testing/iossim/ios...
testing/iossim/iossim.mm:661: deviceName);
On 2012/10/05 12:18:34, rohitrao wrote:
> Here I would indent more to line up with the parens.

Done.

[commit-bot: I haz the power, 2012-10-05 13:09:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lliabraa@chromium.org/10978027/17001

[commit-bot: I haz the power, 2012-10-05 14:21:08]

Retried try job too often for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2012-10-05 14:45:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lliabraa@chromium.org/10978027/17001

[commit-bot: I haz the power, 2012-10-05 16:15:35]

Retried try job too often for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2012-10-05 17:38:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lliabraa@chromium.org/10978027/17001

[commit-bot: I haz the power, 2012-10-05 18:26:49]

Change committed as 160427