Issue 10978022: Center wallpaper picker when open and open author's website in a new window

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10978022: Center wallpaper picker when open and open author's website in a new window (Closed)

Created:
8 years, 2 months ago by bshe

Modified:
8 years, 2 months ago

Reviewers:
dgozman

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Center wallpaper picker when open and open author's website in a new window BUG=151600 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158840

Patch Set 1 #

Patch Set 2 : Fix auto select wallpaper attribution #

Patch Set 3 : #

Patch Set 4 : Only allow one instance of wallpaper picker. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -40 lines)			Patch
M	chrome/browser/chromeos/extensions/wallpaper_manager_util.cc	View	1 2 3	2 chunks	+48 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js	View	1	1 chunk	+26 lines, -32 lines	0 comments	Download
M	chrome/browser/resources/chromeos/wallpaper_manager/main.html	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bshe

Hi Dmitry. Pre discussion with you, this CL use the same launch code as ViewRemovableDrive. ...

8 years, 2 months ago (2012-09-25 15:26:50 UTC) #1

bshe

On 2012/09/26 10:05:39, dgozman wrote: > LGTM Thanks for review. Committing now.

8 years, 2 months ago (2012-09-26 13:47:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/10978022/6001

8 years, 2 months ago (2012-09-26 13:47:43 UTC) #4

Change committed as 158840

Expand Messages | Collapse Messages