Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 10978015: Sort ChromePaths alphabetically for chrome://chrome-urls, etc. (Closed)

Created:
8 years, 3 months ago by msw
Modified:
8 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Sort ChromePaths alphabetically for chrome://chrome-urls, etc. BUG=NONE TEST=The big "List of Chrome URLs" at chrome://chrome-urls (about:about) is sorted alphabetically. R=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158558

Patch Set 1 #

Total comments: 2

Patch Set 2 : Init paths vector from kPaths array. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msw
Hey Nico, please take a look; thanks! This arose from: http://codereview.chromium.org/10980008
8 years, 3 months ago (2012-09-25 03:33:04 UTC) #1
Nico
thanks! https://codereview.chromium.org/10978015/diff/1/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): https://codereview.chromium.org/10978015/diff/1/chrome/browser/browser_about_handler.cc#newcode171 chrome/browser/browser_about_handler.cc:171: paths.push_back(kChromePaths[i]); Can you initialize paths like this: std::vector<std::string> ...
8 years, 2 months ago (2012-09-25 04:12:22 UTC) #2
msw
Please take another look; thanks! https://codereview.chromium.org/10978015/diff/1/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): https://codereview.chromium.org/10978015/diff/1/chrome/browser/browser_about_handler.cc#newcode171 chrome/browser/browser_about_handler.cc:171: paths.push_back(kChromePaths[i]); On 2012/09/25 04:12:22, ...
8 years, 2 months ago (2012-09-25 05:00:51 UTC) #3
Nico
lgtm
8 years, 2 months ago (2012-09-25 05:03:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10978015/6001
8 years, 2 months ago (2012-09-25 05:37:30 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-09-25 13:10:11 UTC) #6
Change committed as 158558

Powered by Google App Engine
This is Rietveld 408576698