vea_unittest: Add --output_log option

content/common/gpu/media/video_encode_accelerator_unittest.cc

Index: content/common/gpu/media/video_encode_accelerator_unittest.cc
diff --git a/content/common/gpu/media/video_encode_accelerator_unittest.cc b/content/common/gpu/media/video_encode_accelerator_unittest.cc
index 73e319afb47afa7875fd62a7416e127e45f98118..89735cb26ec8e1aa0590b7a518e77a1c486d0fd5 100644
--- a/content/common/gpu/media/video_encode_accelerator_unittest.cc
+++ b/content/common/gpu/media/video_encode_accelerator_unittest.cc
@@ -12,6 +12,7 @@
 #include "base/process/process_handle.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
+#include "base/strings/stringprintf.h"
 #include "base/sys_byteorder.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
@@ -356,6 +357,52 @@ static void ParseAndReadTestStreamData(const base::FilePath::StringType& data,
   }
 }
 
+// Basic test environment shared across multiple test cases. We only need to
+// setup it once for all test cases.
+// It helps
+// - maintain test stream data and other test settings.
+// - clean up temporary aligned files.
+// - output log to file.
+class VideoEncodeAcceleratorTestEnvironment : public ::testing::Environment {
+ public:
+  VideoEncodeAcceleratorTestEnvironment(
+      scoped_ptr<base::FilePath::StringType> data,
+      const base::FilePath& log_path,
+      bool run_at_fps)
+      : run_at_fps_(run_at_fps),
+        test_stream_data_(data.Pass()),
+        log_path_(log_path) {}
+
+  virtual void SetUp() {
+    if (!log_path_.empty()) {
+      log_file_.reset(new base::File(
+          log_path_, base::File::FLAG_CREATE_ALWAYS | base::File::FLAG_WRITE));
+      CHECK(log_file_->IsValid());
+    }
+    ParseAndReadTestStreamData(*test_stream_data_, &test_streams_);
+  }
+
+  virtual void TearDown() {
+    for (size_t i = 0; i < test_streams_.size(); i++) {
+      base::DeleteFile(test_streams_[i]->aligned_in_file, false);
+    }
+    log_file_.reset();
+  }
+
+  void LogToFile(const std::string& s) {
+    if (log_file_)
+      log_file_->WriteAtCurrentPos(s.data(), s.length());
+  }
+
+  ScopedVector<TestStream> test_streams_;
+  bool run_at_fps_;
+
+ private:
+  scoped_ptr<base::FilePath::StringType> test_stream_data_;
+  base::FilePath log_path_;
+  scoped_ptr<base::File> log_file_;

[Pawel Osciak, 2015/04/27 02:08:56]

Please document the log format somewhere.

[Justin Chuang, 2015/04/27 07:42:05]

Done.

+};
+
 enum ClientState {
   CS_CREATED,
   CS_ENCODER_SET,
@@ -1134,6 +1181,8 @@ bool VEAClient::HandleEncodedFrame(bool keyframe) {
 void VEAClient::VerifyPerf() {
   double measured_fps = frames_per_second();
   LOG(INFO) << "Measured encoder FPS: " << measured_fps;
+  g_env->LogToFile(
+      base::StringPrintf("Measured encoder FPS: %.3f", measured_fps));
   if (test_perf_)
     EXPECT_GE(measured_fps, kMinPerfFPS);
 }
@@ -1201,34 +1250,6 @@ void VEAClient::WriteIvfFrameHeader(int frame_index, size_t frame_size) {
       reinterpret_cast<char*>(&header), sizeof(header)));
 }
 
-// Setup test stream data and delete temporary aligned files at the beginning
-// and end of unittest. We only need to setup once for all test cases.
-class VideoEncodeAcceleratorTestEnvironment : public ::testing::Environment {
- public:
-  VideoEncodeAcceleratorTestEnvironment(
-      scoped_ptr<base::FilePath::StringType> data,
-      bool run_at_fps) {
-    test_stream_data_ = data.Pass();
-    run_at_fps_ = run_at_fps;
-  }
-
-  virtual void SetUp() {
-    ParseAndReadTestStreamData(*test_stream_data_, &test_streams_);
-  }
-
-  virtual void TearDown() {
-    for (size_t i = 0; i < test_streams_.size(); i++) {
-      base::DeleteFile(test_streams_[i]->aligned_in_file, false);
-    }
-  }
-
-  ScopedVector<TestStream> test_streams_;
-  bool run_at_fps_;
-
- private:
-  scoped_ptr<base::FilePath::StringType> test_stream_data_;
-};
-
 // Test parameters:
 // - Number of concurrent encoders. The value takes effect when there is only
 //   one input stream; otherwise, one encoder per input stream will be
@@ -1379,6 +1400,8 @@ int main(int argc, char** argv) {
   DCHECK(cmd_line);
 
   bool run_at_fps = false;
+  base::FilePath log_path;
+
   base::CommandLine::SwitchMap switches = cmd_line->GetSwitches();
   for (base::CommandLine::SwitchMap::const_iterator it = switches.begin();
        it != switches.end();
@@ -1387,6 +1410,12 @@ int main(int argc, char** argv) {
       test_stream_data->assign(it->second.c_str());
       continue;
     }
+    // Output machine-readable logs with fixed formats to a file.
+    if (it->first == "output_log") {
+      log_path = base::FilePath(
+          base::FilePath::StringType(it->second.begin(), it->second.end()));

[Pawel Osciak, 2015/04/27 02:08:56]

Would

log_path = base::FilePath(it->second)

work?

[Justin Chuang, 2015/04/27 07:42:05]

it->second is base:string16 on OS_WIN, which is wstring on OS_WIN, and
FilePath::StringType is also wstring on OS_WIN.
(Note that base::string16 may be different than wstring on other platforms.)

So yes, it happens to be correct to initialize with it->second. But the type
conversion is not straightforward. Use iterator can convert combinations of
std::string and wstring.
How do you think?

+      continue;
+    }
     if (it->first == "num_frames_to_encode") {
       std::string input(it->second.begin(), it->second.end());
       CHECK(base::StringToInt(input, &content::g_num_frames_to_encode));
@@ -1411,7 +1440,7 @@ int main(int argc, char** argv) {
       reinterpret_cast<content::VideoEncodeAcceleratorTestEnvironment*>(
           testing::AddGlobalTestEnvironment(
               new content::VideoEncodeAcceleratorTestEnvironment(
-                  test_stream_data.Pass(), run_at_fps)));
+                  test_stream_data.Pass(), log_path, run_at_fps)));
 
   return RUN_ALL_TESTS();
 }