Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 10977036: Linux: move dbus-glib target to chromeos-specific section, (Closed)

Created:
8 years, 2 months ago by Paweł Hajdan Jr.
Modified:
8 years, 2 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: move dbus-glib target to chromeos-specific section, to avoid introducing unnecessary build-time dependency on non-chromeos Linux. This has been raised as Gentoo bug https://bugs.gentoo.org/show_bug.cgi?id=434346 and I've confirmed the problem and the fix. TEST=none BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M build/linux/system.gyp View 2 chunks +22 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Paweł Hajdan Jr.
8 years, 2 months ago (2012-09-26 14:16:13 UTC) #1
satorux1
LGTM. hashimoto@, I thought we were almost ready to eliminate the dependency to dbus-glib for ...
8 years, 2 months ago (2012-09-26 14:44:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/10977036/1
8 years, 2 months ago (2012-09-26 18:20:50 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-09-26 18:40:19 UTC) #4
hashimoto
On 2012/09/26 14:44:46, satorux1 wrote: > LGTM. > > hashimoto@, I thought we were almost ...
8 years, 2 months ago (2012-09-27 04:13:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/10977036/1
8 years, 2 months ago (2012-09-27 06:39:39 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-09-27 07:39:53 UTC) #7
Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698