Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 10977023: Remove --use-leveldb-for-gdata (Closed)

Created:
8 years, 2 months ago by achuithb
Modified:
8 years, 2 months ago
Reviewers:
satorux1, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Remove --use-leveldb-for-gdata BUG=149009 TEST=compiles. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
achuithb
Please review. Thanks!
8 years, 2 months ago (2012-09-25 21:57:56 UTC) #1
satorux1
LGTM
8 years, 2 months ago (2012-09-25 22:01:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/10977023/1
8 years, 2 months ago (2012-09-25 22:04:25 UTC) #3
commit-bot: I haz the power
Presubmit check for 10977023-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-09-25 22:04:30 UTC) #4
achuithb
Scott: Can I get an OWNER lgtm? Thank you!
8 years, 2 months ago (2012-09-25 22:09:25 UTC) #5
sky
LGTM
8 years, 2 months ago (2012-09-25 22:24:36 UTC) #6
achuithb
On 2012/09/25 22:24:36, sky wrote: > LGTM Thank you!
8 years, 2 months ago (2012-09-25 22:36:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/10977023/1
8 years, 2 months ago (2012-09-25 22:36:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/10977023/1
8 years, 2 months ago (2012-09-26 00:13:36 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 00:35:31 UTC) #10
Change committed as 158702

Powered by Google App Engine
This is Rietveld 408576698