Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 10977016: Fixing issue with Talk window getting maximized, minimized, restored and leaving it in a desolate s… (Closed)

Created:
8 years, 2 months ago by Mr4D (OOO till 08-26)
Modified:
8 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fixing issue with Talk window getting maximized, minimized, restored and leaving it in a desolate state. I will create a unit test for this (if you want) - but let us first land this since this is a beta blocker. BUG=151698 TEST=visual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158868

Patch Set 1 #

Patch Set 2 : Real fix. #

Patch Set 3 : Added comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ash/wm/workspace/workspace_manager2.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
8 years, 2 months ago (2012-09-26 00:23:26 UTC) #1
sky
LGTM. Be sure to update the comment as to why this is needed and look ...
8 years, 2 months ago (2012-09-26 03:54:05 UTC) #2
Mr4D (OOO till 08-26)
Wanted to do that 'self nit' already myself - but was too tired yesterday when ...
8 years, 2 months ago (2012-09-26 14:04:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/10977016/7001
8 years, 2 months ago (2012-09-26 14:04:28 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) remoting_unittests
8 years, 2 months ago (2012-09-26 17:36:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/10977016/7001
8 years, 2 months ago (2012-09-26 17:39:03 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 20:04:50 UTC) #7
Change committed as 158868

Powered by Google App Engine
This is Rietveld 408576698