Rename HyperbolicDownloadItemNotifer -> AllDownloadItemNotifier

Rename HyperbolicDownloadItemNotifer -> AllDownloadItemNotifier
https://www.google.com/moderator/#15/e=1fccc4&t=1fccc4.40

Reviewers:
brettw: chrome/*.gyp
estade: webui/downloads_dom_handler.*
Done:
rdsmith:*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158484

[benjhayden, 2012-09-24 14:05:57]

PTAL

[Nico, 2012-09-24 14:10:27]

thanks!

do you need to update some gyp file too?

[Randy Smith (Not in Mondays), 2012-09-24 16:03:48]

LGTM.

http://codereview.chromium.org/10974009/diff/12002/chrome/browser/download/al...
File chrome/browser/download/all_download_item_notifier.h (right):

http://codereview.chromium.org/10974009/diff/12002/chrome/browser/download/al...
chrome/browser/download/all_download_item_notifier.h:19: // class AndAHalf :
public AllDownloadItemNotifier::Observer {
HyperboleAndAHalf?  (I.e. current name doesn't make any sense given the name
change.)

[benjhayden, 2012-09-24 16:46:29]

http://codereview.chromium.org/10974009/diff/12002/chrome/browser/download/al...
File chrome/browser/download/all_download_item_notifier.h (right):

http://codereview.chromium.org/10974009/diff/12002/chrome/browser/download/al...
chrome/browser/download/all_download_item_notifier.h:19: // class AndAHalf :
public AllDownloadItemNotifier::Observer {
On 2012/09/24 16:03:48, rdsmith wrote:
> HyperboleAndAHalf?  (I.e. current name doesn't make any sense given the name
> change.)

Done.

[commit-bot: I haz the power, 2012-09-24 17:01:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10974009/1014

[commit-bot: I haz the power, 2012-09-24 17:01:08]

Presubmit check for 10974009-1014 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/browser/ui/webui

Presubmit checks took 1.3s to calculate.

[benjhayden, 2012-09-24 17:05:02]

James, PTAL?

[benjhayden, 2012-09-24 20:13:44]

Brett, Evan, PTAL?

[Nico, 2012-09-24 22:44:12]

lgtm with th egyp change

[commit-bot: I haz the power, 2012-09-24 22:45:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10974009/1014

[commit-bot: I haz the power, 2012-09-25 01:10:00]

Change committed as 158484

[Evan Stade, 2012-09-25 06:14:45]

webui lgtm