Issue 10972018: Changing USB API buffer ownership.

Issue 10972018: Changing USB API buffer ownership. (Closed)

Created:
8 years, 2 months ago by Garret Kelly

Modified:
8 years, 2 months ago

Reviewers:
asargent_no_longer_on_chrome, Leandro Graciá Gil

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Changing USB API buffer ownership. This change changes the ownership of the buffer used in the final transfer callback to the UsbDevice itself instead of having the USB API keep a reference to its own buffer. BUG=151987 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158608

Patch Set 1 #

Patch Set 2 : Fixing tests. #

Patch Set 3 : Don't expose control transfer header, report correct transfer size. #

Patch Set 4 : Don't leak uninitialized memory into caller. #

Total comments: 2

Patch Set 5 : Style fix, don't memset. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -29 lines)			Patch
M	chrome/browser/extensions/api/usb/usb_apitest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/usb/usb_device_resource.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/usb/usb_device_resource.cc	View	1	4 chunks	+11 lines, -14 lines	0 comments	Download
M	chrome/browser/usb/usb_device.h	View	1 2 3 4	3 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/usb/usb_device.cc	View	1 2 4	8 chunks	+26 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Leandro Graciá Gil

lgtm. I've tested this new patch and it works great! Thanks for the fix. https://codereview.chromium.org/10972018/diff/20002/chrome/browser/usb/usb_device.h ...

8 years, 2 months ago (2012-09-25 09:55:47 UTC) #1

Garret Kelly

Glad to hear it works. https://codereview.chromium.org/10972018/diff/20002/chrome/browser/usb/usb_device.h File chrome/browser/usb/usb_device.h (right): https://codereview.chromium.org/10972018/diff/20002/chrome/browser/usb/usb_device.h#newcode126 chrome/browser/usb/usb_device.h:126: void SubmitTransfer(PlatformUsbTransferHandle handle, bool ...

8 years, 2 months ago (2012-09-25 15:02:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/10972018/23001

8 years, 2 months ago (2012-09-25 15:16:24 UTC) #4

Change committed as 158608

Expand Messages | Collapse Messages