Issue 10972011: Allow optimistically hoisting elements transitions over accesses.

Issue 10972011: Allow optimistically hoisting elements transitions over accesses. (Closed)

Created:
8 years, 3 months ago by Toon Verwaest

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Allow optimistically hoisting elements transitions over accesses. Committed: https://code.google.com/p/v8/source/detail?r=12642

Patch Set 2 : Addressed comments #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -50 lines)			Patch
M	src/hydrogen.cc	View		1 chunk	+0 lines, -46 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	test/mjsunit/elements-transition-hoisting.js	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

Drive-by comments. https://chromiumcodereview.appspot.com/10972011/diff/2001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://chromiumcodereview.appspot.com/10972011/diff/2001/src/hydrogen-instructions.h#newcode4666 src/hydrogen-instructions.h:4666: SetGVNFlag(kChangesNewSpacePromotion); The kChangesNewSpacePromotion is mainly used for ...

8 years, 2 months ago (2012-10-01 13:13:48 UTC) #2

danno

lgtm with comments https://chromiumcodereview.appspot.com/10972011/diff/2001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://chromiumcodereview.appspot.com/10972011/diff/2001/src/hydrogen-instructions.h#newcode4666 src/hydrogen-instructions.h:4666: SetGVNFlag(kChangesNewSpacePromotion); Please restore the original code ...

8 years, 2 months ago (2012-10-01 14:08:47 UTC) #3

Toon Verwaest

8 years, 2 months ago (2012-10-01 14:57:51 UTC) #4

Addressed comments.

https://chromiumcodereview.appspot.com/10972011/diff/2001/src/hydrogen-instru...
File src/hydrogen-instructions.h (right):

https://chromiumcodereview.appspot.com/10972011/diff/2001/src/hydrogen-instru...
src/hydrogen-instructions.h:4666: SetGVNFlag(kChangesNewSpacePromotion);
On 2012/10/01 14:08:47, danno wrote:
> Please restore the original code with ifs, but still remove the comment, which
> is no longer valid.

Done.

Expand Messages | Collapse Messages