Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 10971003: Moves HTTP POST handling to JS. (Closed)

Created:
8 years, 3 months ago by Toscano
Modified:
8 years, 3 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews, arv (Not doing code reviews)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Moves HTTP POST handling to JS. BUG=128276 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158057

Patch Set 1 #

Patch Set 2 : Merge with trunk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -71 lines) Patch
M chrome/browser/resources/print_preview/cloud_print_interface.js View 6 chunks +44 lines, -12 lines 0 comments Download
M chrome/browser/resources/print_preview/data/print_ticket_store.js View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 1 chunk +1 line, -11 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 4 chunks +3 lines, -45 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Toscano
8 years, 3 months ago (2012-09-21 07:58:16 UTC) #1
Albert Bodenhamer
lgtm
8 years, 3 months ago (2012-09-21 16:27:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rltoscano@chromium.org/10971003/1
8 years, 3 months ago (2012-09-21 16:31:50 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/webui/print_preview/print_preview_handler.cc: While running patch -p1 --forward --force; patching file chrome/browser/ui/webui/print_preview/print_preview_handler.cc ...
8 years, 3 months ago (2012-09-21 16:31:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rltoscano@chromium.org/10971003/6001
8 years, 3 months ago (2012-09-21 16:42:53 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 20:06:46 UTC) #6
Change committed as 158057

Powered by Google App Engine
This is Rietveld 408576698