Log ChromeToMobile search and auth errors to UMA and INFO.

Log ChromeToMobile search and auth errors to UMA and INFO.

Add more UMA and VLOG(0) to OnGetTokenFailure and HandleSearchResponse.
(add supporting GoogleServiceAuthError::NUM_STATES enum value)
(add supporting CTMService SEARCH_[SUCCESS|ERROR] enum values)
(change existing LOG_IF(INFO, ...) to VLOG_IF(0, ...) in HandleSubmitResponse)

ChromeToMobile.AuthError UMA histogram added here:
https://chromereviews.googleplex.com/4964015

BUG=102709, 120941
TEST=Additional UMA and INFO logging of any auth token generation errors.
R=joi@chromium.org,sky@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158345

[msw, 2012-09-22 03:47:24]

Scott, please review chrome/browser/chrome_to_mobile_service.[h|cc], thanks!
Jói, please review: google_apis/gaia/google_service_auth_error.h, thanks!

[Jói, 2012-09-22 12:01:27]

LGTM

[sky, 2012-09-24 14:00:25]

https://codereview.chromium.org/10970055/diff/7001/chrome/browser/chrome_to_m...
File chrome/browser/chrome_to_mobile_service.cc (right):

https://codereview.chromium.org/10970055/diff/7001/chrome/browser/chrome_to_m...
chrome/browser/chrome_to_mobile_service.cc:402: LOG(INFO) << "ChromeToMobile
auth failed: " << error.ToString();
Use VLOG

https://codereview.chromium.org/10970055/diff/7001/chrome/browser/chrome_to_m...
chrome/browser/chrome_to_mobile_service.cc:651: LOG_IF(INFO, !success) <<
"ChromeToMobile search failed (" <<
VLOG

[sky, 2012-09-24 14:00:32]

LGTM once you switch to VLOG

[msw, 2012-09-24 17:23:20]

Done; landing. FYI, I had explicitly chosen LOG over VLOG to catch unexpected
errors after-the-fact, but this hasn't happened, so limiting utility to
reproducible problems and --v=0 seems acceptable.

https://codereview.chromium.org/10970055/diff/7001/chrome/browser/chrome_to_m...
File chrome/browser/chrome_to_mobile_service.cc (right):

https://codereview.chromium.org/10970055/diff/7001/chrome/browser/chrome_to_m...
chrome/browser/chrome_to_mobile_service.cc:402: LOG(INFO) << "ChromeToMobile
auth failed: " << error.ToString();
On 2012/09/24 14:00:25, sky wrote:
> Use VLOG

Done.

https://codereview.chromium.org/10970055/diff/7001/chrome/browser/chrome_to_m...
chrome/browser/chrome_to_mobile_service.cc:651: LOG_IF(INFO, !success) <<
"ChromeToMobile search failed (" <<
On 2012/09/24 14:00:25, sky wrote:
> VLOG

Done.

https://codereview.chromium.org/10970055/diff/7001/chrome/browser/chrome_to_m...
chrome/browser/chrome_to_mobile_service.cc:679: LOG_IF(INFO, !success) <<
"ChromeToMobile send failed (" <<
Also changed this.

[commit-bot: I haz the power, 2012-09-24 17:24:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/10970055/9010

[commit-bot: I haz the power, 2012-09-24 19:20:20]

Change committed as 158345