Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10970054: Check ChromeToMobileService OriginalURLs before handling. (Closed)

Created:
8 years, 3 months ago by msw
Modified:
8 years, 3 months ago
Reviewers:
nyquist, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Check ChromeToMobileService OriginalURLs before handling. Example one-day UMA shows "Send Success" > "Sending URL" + "Sending Snapshot": https://gfsviewer.corp.google.com/cns/pa-d/home/uma-data/public/dashboards/histograms.html?dayCount=1&endDate=09-21-2012&version=24.0.1273.0-W&group=ChromeToMobile&histogram=Service&otherVersions=10 Perhaps these URLs may be redirected? This CL checks the *original* URLs before handling. This speculative fix should be safe even if it doesn't address the root issue. BUG=102709, 120941 TEST=UMA data doesn't report (send success+failure) > (send URL+snapshot). R=nyquist@chromium.org,sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158352

Patch Set 1 #

Patch Set 2 : Check submit URL before handling as such, etc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/chrome_to_mobile_service.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Hey Tommy and Scott, please take a look; thanks!
8 years, 3 months ago (2012-09-22 00:52:16 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-09-24 13:51:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10970054/2001
8 years, 3 months ago (2012-09-24 16:58:58 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-24 19:34:55 UTC) #4
Change committed as 158352

Powered by Google App Engine
This is Rietveld 408576698