Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: ash/launcher/launcher_context_menu.cc

Issue 10969076: Revert of AutoHide Behavior (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/ash_strings.grd ('k') | ash/launcher/launcher_context_menu_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/launcher/launcher_context_menu.cc
diff --git a/ash/launcher/launcher_context_menu.cc b/ash/launcher/launcher_context_menu.cc
index f2ea498aabd77ec28b2b85208e7995979177ac92..0b307dcfff3a3433533cdec07caf4d4eba398911 100644
--- a/ash/launcher/launcher_context_menu.cc
+++ b/ash/launcher/launcher_context_menu.cc
@@ -25,19 +25,38 @@ LauncherContextMenu::~LauncherContextMenu() {
// static
bool LauncherContextMenu::IsAutoHideMenuHideChecked() {
- return ash::SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS ==
+ internal::RootWindowController* controller =
+ Shell::GetPrimaryRootWindowController();
+ ash::ShelfAutoHideBehavior auto_hide_behavior =
Shell::GetInstance()->GetShelfAutoHideBehavior();
+ return (controller->IsInMaximizedMode() &&
+ (auto_hide_behavior == ash::SHELF_AUTO_HIDE_BEHAVIOR_DEFAULT ||
+ auto_hide_behavior == ash::SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS)) ||
+ (!controller->IsInMaximizedMode() &&
+ auto_hide_behavior == ash::SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);
}
// static
ShelfAutoHideBehavior LauncherContextMenu::GetToggledAutoHideBehavior() {
- return IsAutoHideMenuHideChecked() ? ash::SHELF_AUTO_HIDE_BEHAVIOR_NEVER :
- ash::SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS;
+ ash::ShelfAutoHideBehavior auto_hide_behavior;
+ if (Shell::GetPrimaryRootWindowController()->IsInMaximizedMode()) {
+ if (IsAutoHideMenuHideChecked())
+ auto_hide_behavior = ash::SHELF_AUTO_HIDE_BEHAVIOR_NEVER;
+ else
+ auto_hide_behavior = ash::SHELF_AUTO_HIDE_BEHAVIOR_DEFAULT;
+ } else if (IsAutoHideMenuHideChecked()) {
+ auto_hide_behavior = ash::SHELF_AUTO_HIDE_BEHAVIOR_DEFAULT;
+ } else {
+ auto_hide_behavior = ash::SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS;
+ }
+ return auto_hide_behavior;
}
// static
int LauncherContextMenu::GetAutoHideResourceStringId() {
- return IDS_AURA_LAUNCHER_CONTEXT_MENU_AUTO_HIDE;
+ return Shell::GetPrimaryRootWindowController()->IsInMaximizedMode() ?
+ IDS_AURA_LAUNCHER_CONTEXT_MENU_AUTO_HIDE_MAXIMIZED :
+ IDS_AURA_LAUNCHER_CONTEXT_MENU_AUTO_HIDE_NOT_MAXIMIZED;
}
bool LauncherContextMenu::IsCommandIdChecked(int command_id) const {
« no previous file with comments | « ash/ash_strings.grd ('k') | ash/launcher/launcher_context_menu_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698