Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 10969076: Revert of AutoHide Behavior (Closed)

Created:
8 years, 3 months ago by Harry McCleave
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -49 lines) Patch
M ash/ash_strings.grd View 1 chunk +4 lines, -1 line 0 comments Download
M ash/launcher/launcher_context_menu.cc View 1 chunk +23 lines, -4 lines 0 comments Download
M ash/launcher/launcher_context_menu_unittest.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/screen_ash_unittest.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 5 chunks +10 lines, -4 lines 0 comments Download
M ash/wm/shelf_types.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_manager2_unittest.cc View 7 chunks +6 lines, -7 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Harry McCleave
Reverting to remove String Change (will be reimplemented in http://code.google.com/p/chromium/issues/detail?id=151417).
8 years, 3 months ago (2012-09-24 18:30:12 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 3 months ago (2012-09-24 18:31:16 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 3 months ago (2012-09-24 21:02:02 UTC) #3
sky
LGTM
8 years, 3 months ago (2012-09-24 21:03:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harrym@chromium.org/10969076/1
8 years, 3 months ago (2012-09-24 21:04:20 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-24 23:02:51 UTC) #6
Change committed as 158436

Powered by Google App Engine
This is Rietveld 408576698