Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 10969071: [Android] Install a WebContentsObserverAndroid in android_webview. (Closed)

Created:
8 years, 3 months ago by benm (inactive)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Android] Install a WebContentsObserverAndroid in android_webview. To proxy WebContentsObserverAndroid calls to the embedder, we need to create an instance of the observer. Android trybots are green and only touches java, so no need for CQ to look at other bots. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158306

Patch Set 1 #

Total comments: 2

Patch Set 2 : add assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsClient.java View 1 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
benm (inactive)
ptal
8 years, 3 months ago (2012-09-24 15:05:39 UTC) #1
mkosiba (inactive)
lgtm http://codereview.chromium.org/10969071/diff/1/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java File android_webview/java/src/org/chromium/android_webview/AwContentsClient.java (right): http://codereview.chromium.org/10969071/diff/1/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java#newcode133 android_webview/java/src/org/chromium/android_webview/AwContentsClient.java:133: if (mWebContentsObserver == null) { throw if != ...
8 years, 3 months ago (2012-09-24 15:08:52 UTC) #2
benm (inactive)
http://codereview.chromium.org/10969071/diff/1/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java File android_webview/java/src/org/chromium/android_webview/AwContentsClient.java (right): http://codereview.chromium.org/10969071/diff/1/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java#newcode133 android_webview/java/src/org/chromium/android_webview/AwContentsClient.java:133: if (mWebContentsObserver == null) { yeah, after I uploaded ...
8 years, 3 months ago (2012-09-24 15:11:18 UTC) #3
Yusuf
lgtm
8 years, 3 months ago (2012-09-24 17:31:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/10969071/5001
8 years, 3 months ago (2012-09-24 17:31:47 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-24 17:31:57 UTC) #6
Change committed as 158306

Powered by Google App Engine
This is Rietveld 408576698