Issue 10969069: Fast path for symbol lookup in JSON.parse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10969069: Fast path for symbol lookup in JSON.parse. (Closed)

Created:
8 years, 2 months ago by Yang

Modified:
8 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Google), Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fast path for symbol lookup in JSON.parse. R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12598

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -26 lines)
M	src/json-parser.h	View	2 chunks	+48 lines, -2 lines	0 comments
M	src/objects.h	View	4 chunks	+26 lines, -7 lines	2 comments
M	src/objects.cc	View	1 chunk	+0 lines, -1 line	0 comments
M	src/objects-inl.h	View	4 chunks	+23 lines, -16 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

dbc https://chromiumcodereview.appspot.com/10969069/diff/1/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10969069/diff/1/src/objects.h#newcode2920 src/objects.h:2920: inline static uint32_t NextProbe( If you want to ...

8 years, 2 months ago (2012-09-26 15:12:14 UTC) #3

Yang

8 years, 2 months ago (2012-09-26 15:14:43 UTC) #4

https://chromiumcodereview.appspot.com/10969069/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/10969069/diff/1/src/objects.h#newcode2920
src/objects.h:2920: inline static uint32_t NextProbe(
On 2012/09/26 15:12:14, Vyacheslav Egorov (Google) wrote:
> If you want to _force_ inlining consider using INLINE macro.
> 
> inline is just a hint that might be ignored by the compiler (e.g. due to
> inlining budget constraints).

I'll do some experiments on whether this makes any difference.

Expand Messages | Collapse Messages