Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2921)

Issue 10969069: Fast path for symbol lookup in JSON.parse. (Closed)

Created:
6 years, 11 months ago by Yang
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fast path for symbol lookup in JSON.parse. R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12598

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -26 lines) Patch
M src/json-parser.h View 2 chunks +48 lines, -2 lines 0 comments Download
M src/objects.h View 4 chunks +26 lines, -7 lines 2 comments Download
M src/objects.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 4 chunks +23 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 11 months ago (2012-09-24 13:49:57 UTC) #1
Toon Verwaest
lgtm
6 years, 11 months ago (2012-09-24 14:12:04 UTC) #2
Vyacheslav Egorov (Google)
dbc https://chromiumcodereview.appspot.com/10969069/diff/1/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10969069/diff/1/src/objects.h#newcode2920 src/objects.h:2920: inline static uint32_t NextProbe( If you want to ...
6 years, 11 months ago (2012-09-26 15:12:14 UTC) #3
Yang
6 years, 11 months ago (2012-09-26 15:14:43 UTC) #4
https://chromiumcodereview.appspot.com/10969069/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/10969069/diff/1/src/objects.h#newcode2920
src/objects.h:2920: inline static uint32_t NextProbe(
On 2012/09/26 15:12:14, Vyacheslav Egorov (Google) wrote:
> If you want to _force_ inlining consider using INLINE macro.
> 
> inline is just a hint that might be ignored by the compiler (e.g. due to
> inlining budget constraints).

I'll do some experiments on whether this makes any difference.

Powered by Google App Engine
This is Rietveld 408576698