Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10969065: [Android] In PERSONALITY_VIEW, wait for settings to be applied native side. (Closed)

Created:
8 years, 3 months ago by benm (inactive)
Modified:
8 years, 3 months ago
Reviewers:
bulach, mnaganov (inactive), android-webview-reviews, mnaganov
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Android] In PERSONALITY_VIEW, wait for settings to be applied native side. When running in PERSONALITY_VIEW and a ContentSettings method is called on a background thread, we must wait for the setting to be applied on the native side before returning. This ensures that the setting has taken effect for subsequent WebView usage. Ran the android trybots manually in codereview and only touches java, so no need for CQ to run all the other bots. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -38 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentSettings.java View 25 chunks +59 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
benm (inactive)
ptal! Mikhail, this is the same as the downstream patch. Marcus, please take a look ...
8 years, 3 months ago (2012-09-24 11:05:16 UTC) #1
bulach
lgtm when mikhail is happy :)
8 years, 3 months ago (2012-09-24 11:18:07 UTC) #2
mnaganov (inactive)
lgtm
8 years, 3 months ago (2012-09-24 12:21:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/10969065/1
8 years, 3 months ago (2012-09-24 12:22:41 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-24 12:22:48 UTC) #5
Change committed as 158259

Powered by Google App Engine
This is Rietveld 408576698