base: No need to inherit testing::Test in base64 unittest.

base: No need to inherit testing::Test in base64 unittest.

TEST=base_unittests
TBR=willchan@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158203

[commit-bot: I haz the power, 2012-09-23 02:20:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/10969059/1

[tfarina, 2012-09-23 02:20:41]

TBRing...

[willchan no longer on Chromium, 2012-09-23 02:24:20]

lgtm


On Sat, Sep 22, 2012 at 7:20 PM, <tfarina@chromium.org> wrote:

> Reviewers: willchan,
>
> Message:
> TBRing...
>
> Description:
> base: No need to inherit testing::Test in base64 unittest.
>
> TEST=base_unittests
> TBR=willchan@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10969059/<http://codereview.chromium.org/109...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M base/base64_unittest.cc
>
>
> Index: base/base64_unittest.cc
> diff --git a/base/base64_unittest.cc b/base/base64_unittest.cc
> index 1d11b1eb10850b3168b6dcbcbbc04f**1c58c7f37b..**
> 9a5dd818e069a52fe5ee7463ddda68**17c80022e8 100644
> --- a/base/base64_unittest.cc
> +++ b/base/base64_unittest.cc
> @@ -1,29 +1,28 @@
> -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
> +// Copyright (c) 2012 The Chromium Authors. All rights reserved.
>  // Use of this source code is governed by a BSD-style license that can be
>  // found in the LICENSE file.
>
>  #include "base/base64.h"
> -#include "testing/gtest/include/gtest/**gtest.h"
> -
> -namespace {
>
> -class Base64Test : public testing::Test {
> -};
> +#include "testing/gtest/include/gtest/**gtest.h"
>
> -}  // namespace
> +namespace base {
>
>  TEST(Base64Test, Basic) {
>    const std::string kText = "hello world";
>    const std::string kBase64Text = "aGVsbG8gd29ybGQ=";
>
> -  std::string encoded, decoded;
> +  std::string encoded;
> +  std::string decoded;
>    bool ok;
>
> -  ok = base::Base64Encode(kText, &encoded);
> +  ok = Base64Encode(kText, &encoded);
>    EXPECT_TRUE(ok);
>    EXPECT_EQ(kBase64Text, encoded);
>
> -  ok = base::Base64Decode(encoded, &decoded);
> +  ok = Base64Decode(encoded, &decoded);
>    EXPECT_TRUE(ok);
>    EXPECT_EQ(kText, decoded);
>  }
> +
> +}  // namespace base
>
>
>

[commit-bot: I haz the power, 2012-09-23 04:51:05]

Change committed as 158203