CSS tweaks for wallpaper manager

CSS tweaks for wallpaper manager


BUG=151602
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158360

[bshe, 2012-09-21 22:27:17]

Hi Kevin.

I briefly talked to you about the extra vertical space between two rows of
thumbnails. It looks like the space is associated with inline-block. When
inline-block wraps, it has some extra space between two lines.

If I use font-size: 0, the extra space goes away. But I am not sure if this is
too hacky. I remember you have some experiences dealing with spaces between to
lines. Could you please review this patch? Thanks!

[kevers, 2012-09-24 14:09:17]

https://codereview.chromium.org/10969049/diff/1/chrome/browser/resources/chro...
File
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
(right):

https://codereview.chromium.org/10969049/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:91:
font-size: 0;
Does "line-height: 100%;" work?  If so, I believe it would be less hacky.

[bshe, 2012-09-24 14:46:51]

thanks!

https://codereview.chromium.org/10969049/diff/1/chrome/browser/resources/chro...
File
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
(right):

https://codereview.chromium.org/10969049/diff/1/chrome/browser/resources/chro...
chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css:91:
font-size: 0;
Yes. It works.

Done!

On 2012/09/24 14:09:17, kevers wrote:
> Does "line-height: 100%;" work?  If so, I believe it would be less hacky.

[kevers, 2012-09-24 14:52:24]

lgtm

[bshe, 2012-09-24 17:58:10]

On 2012/09/24 14:52:24, kevers wrote:
> lgtm

Thanks!

[commit-bot: I haz the power, 2012-09-24 17:58:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/10969049/4001

[commit-bot: I haz the power, 2012-09-24 19:50:49]

Change committed as 158360