cros: Implement default app ordering.

cros: Implement default app ordering.

- Support more default app ordering than just web store app;
- Add default app ordering for ChromeOS;
- Add tests for default ordering;

BUG=149750
TEST=Verify it does not break NTP page on non-chromeos. And for chromeos, wait until app list CL that respects NTP ordering is landed.

R=csharp@chromium.org,asargent@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158472

[asargent_no_longer_on_chrome, 2012-09-21 22:27:49]

I'll defer to csharp on the extension_sorting.{h,cc} files since it looks like
he's done a lot of work on them in the past.

The rest of the extensions changes LGTM.

[csharp, 2012-09-24 14:09:44]

http://codereview.chromium.org/10969044/diff/2001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_sorting.cc (right):

http://codereview.chromium.org/10969044/diff/2001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_sorting.cc:603: syncer::StringOrdinal
next_ordinal = app_launch_ordinal.CreateAfter();
I think this section should be replaced by:
return app_launch_ordinal.CreateBetween(page.find(app_launch_ordinal) + 1)

This way the app launch ordinal appears right after the one it conflicted with
(which I assume is the intended behavior)

[xiyuan, 2012-09-24 16:37:12]

http://codereview.chromium.org/10969044/diff/2001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_sorting.cc (right):

http://codereview.chromium.org/10969044/diff/2001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_sorting.cc:603: syncer::StringOrdinal
next_ordinal = app_launch_ordinal.CreateAfter();
On 2012/09/24 14:09:45, csharp wrote:
> I think this section should be replaced by:
> return app_launch_ordinal.CreateBetween(page.find(app_launch_ordinal) + 1)
> 
> This way the app launch ordinal appears right after the one it conflicted with
> (which I assume is the intended behavior)  

Done. Good call. This is much better than using a loop.

[csharp, 2012-09-24 16:41:17]

lgtm

[commit-bot: I haz the power, 2012-09-24 22:27:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10969044/15001

[commit-bot: I haz the power, 2012-09-25 00:55:40]

Change committed as 158472