Issue 10969032: [cros] Avatar picker: various fixes for web camera problems.

Issue 10969032: [cros] Avatar picker: various fixes for web camera problems. (Closed)

Created:
8 years, 3 months ago by Ivan Korotkov

Modified:
8 years, 3 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros] Avatar picker: various fixes for web camera problems. BUG=151408 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158045

Patch Set 4 : Cleanup #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -12 lines)			Patch
M	chrome/browser/resources/chromeos/login/oobe_screen_user_image.js	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/chromeos/user_images_grid.js	View	1 2	8 chunks	+19 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos/change_picture_options.js	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm http://codereview.chromium.org/10969032/diff/3001/chrome/browser/resources/chromeos/user_images_grid.js File chrome/browser/resources/chromeos/user_images_grid.js (right): http://codereview.chromium.org/10969032/diff/3001/chrome/browser/resources/chromeos/user_images_grid.js#newcode299 chrome/browser/resources/chromeos/user_images_grid.js:299: } this.cameraCheckInProgress_ = false; http://codereview.chromium.org/10969032/diff/3001/chrome/browser/resources/chromeos/user_images_grid.js#newcode464 chrome/browser/resources/chromeos/user_images_grid.js:464: this.checkCameraPresence(function() { ...

8 years, 3 months ago (2012-09-21 16:52:28 UTC) #2

Ivan Korotkov

http://codereview.chromium.org/10969032/diff/3001/chrome/browser/resources/chromeos/user_images_grid.js File chrome/browser/resources/chromeos/user_images_grid.js (right): http://codereview.chromium.org/10969032/diff/3001/chrome/browser/resources/chromeos/user_images_grid.js#newcode299 chrome/browser/resources/chromeos/user_images_grid.js:299: } On 2012/09/21 16:52:28, Nikita Kostylev wrote: > this.cameraCheckInProgress_ ...

8 years, 3 months ago (2012-09-21 16:58:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10969032/8001

8 years, 3 months ago (2012-09-21 17:02:22 UTC) #4

Change committed as 158045

Expand Messages | Collapse Messages