Use an explicit lock object in ContentSettings for synchronisation.

[Android] Use an explicit lock object in ContentSettings for synchronisation.

For code clarity reasons, refactor ContentSettings to use an explicit
lock object and rename methods that expect the caller to hold the lock
as appropriate. Should be no functional change.

NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158100

[benm (inactive), 2012-09-21 10:45:26]

ptal folks!

Mikhail: This is the same as the downstream patch.
Marcus: OWNERS please :)

[bulach, 2012-09-21 12:21:07]

lgtm if mikhail is happy :)
one suggestion below:

https://codereview.chromium.org/10969031/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentSettings.java
(right):

https://codereview.chromium.org/10969031/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentSettings.java:925:
void sendSyncMessage() {
nit: since this is package visible, perhaps add a java-doc?
also, maybe java-doc-ify the one below?

[benm (inactive), 2012-09-21 12:28:30]

thanks marcus!

https://codereview.chromium.org/10969031/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/ContentSettings.java
(right):

https://codereview.chromium.org/10969031/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/ContentSettings.java:925:
void sendSyncMessage() {
I have a change hot on the heels of this one that will remove the method below,
I can add a javadoc to the package one in that CL.

[mnaganov (inactive), 2012-09-21 12:28:32]

lgtm

[commit-bot: I haz the power, 2012-09-21 12:33:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benm@chromium.org/10969031/1

[commit-bot: I haz the power, 2012-09-21 20:15:01]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is 157980

[commit-bot: I haz the power, 2012-09-21 22:33:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benm@chromium.org/10969031/1

[commit-bot: I haz the power, 2012-09-21 22:34:10]

Change committed as 158100