Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 10969020: Make ContentShell create a jar containing its .class output (Closed)

Created:
8 years, 3 months ago by cjhopman
Modified:
8 years, 3 months ago
Reviewers:
Yaron, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Ramya
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make ContentShell create a jar containing its .class output Some other targets depend on the .java files used by content shell. We cannot simply create a jar in the normal way since the content shell java files may depend on the content shell resources. The Android build system creates R.java when content_shell_apk is built. So, to create the jar, we should just package all the output .class files from when the apk is built. This also adds a "fake" target content_shell_java which can be used like all the other jar targets. That is, a target that depends on content_shell_java will have the content_shell jar added to its classpath automatically. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157862

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M content/content_shell.gypi View 1 chunk +40 lines, -0 lines 0 comments Download
M content/shell/android/java/content_shell_apk.xml View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
yfriedman: content/shell/android jam: content/
8 years, 3 months ago (2012-09-20 18:10:02 UTC) #1
Yaron
lgtm
8 years, 3 months ago (2012-09-20 18:45:10 UTC) #2
jam
rubberstamp lgtm for the gyp
8 years, 3 months ago (2012-09-20 19:32:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10969020/2001
8 years, 3 months ago (2012-09-20 20:02:46 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 22:52:32 UTC) #5
Change committed as 157862

Powered by Google App Engine
This is Rietveld 408576698