Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chromeos/dbus/ibus/ibus_engine_service.h

Issue 10968056: Fix crash bug of IME extension API. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/ibus/ibus_engine_service.h
diff --git a/chromeos/dbus/ibus/ibus_engine_service.h b/chromeos/dbus/ibus/ibus_engine_service.h
index a7a11b4c1b83771082f8df5ae55d641b763b530b..f4aaba918ffed8ce33aba50a12641bc2376e2e57 100644
--- a/chromeos/dbus/ibus/ibus_engine_service.h
+++ b/chromeos/dbus/ibus/ibus_engine_service.h
@@ -27,7 +27,7 @@ class IBusText;
typedef ScopedVector<IBusProperty> IBusPropertyList;
} // namespace
-// A interface to handle the engine client method call.
+// A interface to handle the engine handler method call.
class CHROMEOS_EXPORT IBusEngineHandlerInterface {
public:
typedef base::Callback<void (bool consumed)> KeyEventDoneCallback;
@@ -130,8 +130,12 @@ class CHROMEOS_EXPORT IBusEngineService {
virtual ~IBusEngineService();
- // Initializes the engine client. This class takes the ownership of |handler|.
- virtual void Initialize(IBusEngineHandlerInterface* handler) = 0;
+ // Sets a new IBus engine handler and old handler will be overridden.
+ // This class doesn't take the ownership of |handler|.
+ virtual void SetEngine(IBusEngineHandlerInterface* handler) = 0;
+
+ // Unsets the current IBus engine hanlder.
+ virtual void UnsetEngine() = 0;
// Emits RegisterProperties signal.
virtual void RegisterProperties(
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine_ibus.cc ('k') | chromeos/dbus/ibus/ibus_engine_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698