Chromium Code Reviews
Help | Chromium Project | Sign in
(557)

Issue 10968049: Disable right button drag in omnibox (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by simonhong_
Modified:
1 year, 6 months ago
Reviewers:
sky
CC:
chromium-reviews_chromium.org, tfarina, James Su
Base URL:
http://git.chromium.org/chromium/src.git@new
Visibility:
Public.

Description

Disable right button drag in omnibox

Dragging with the right button should never select any text or change any
existing selection.

BUG=128441
TEST=Compiles and Manual Test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158682

Patch Set 1 #

Total comments: 3

Patch Set 2 : Deliver drag event to omnibox_view #

Total comments: 1

Patch Set 3 : Disable right button dragging in Textfield" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Lint Patch
M ui/views/controls/textfield/textfield.h View 1 2 1 chunk +1 line, -0 lines 0 comments ? errors Download
M ui/views/controls/textfield/textfield.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 10
simonhong_
Dear Scott, Please review this patch. Thank you.
1 year, 6 months ago #1
sky
https://codereview.chromium.org/10968049/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right): https://codereview.chromium.org/10968049/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc#newcode117 chrome/browser/ui/views/omnibox/omnibox_view_views.cc:117: views::Textfield::OnMouseReleased(event); Do things get confused without forwarding the release?
1 year, 6 months ago #2
simonhong_
https://codereview.chromium.org/10968049/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right): https://codereview.chromium.org/10968049/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc#newcode117 chrome/browser/ui/views/omnibox/omnibox_view_views.cc:117: views::Textfield::OnMouseReleased(event); You mean context menu also need to disable ...
1 year, 6 months ago #3
sky
https://codereview.chromium.org/10968049/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right): https://codereview.chromium.org/10968049/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc#newcode117 chrome/browser/ui/views/omnibox/omnibox_view_views.cc:117: views::Textfield::OnMouseReleased(event); On 2012/09/24 16:32:21, Simon Hong wrote: > You ...
1 year, 6 months ago #4
simonhong_
I modified delivering drag event to omnibox_view_. Drag event only blocks modifying of text field.
1 year, 6 months ago #5
sky
https://codereview.chromium.org/10968049/diff/5001/chrome/browser/ui/views/omnibox/omnibox_view_views.cc File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right): https://codereview.chromium.org/10968049/diff/5001/chrome/browser/ui/views/omnibox/omnibox_view_views.cc#newcode111 chrome/browser/ui/views/omnibox/omnibox_view_views.cc:111: result = views::Textfield::OnMouseDragged(event); I think we should do this ...
1 year, 6 months ago #6
simonhong_
Dear Scott, I implemented in Textfield. Thank you. On 2012/09/24 20:54:08, sky wrote: > https://codereview.chromium.org/10968049/diff/5001/chrome/browser/ui/views/omnibox/omnibox_view_views.cc ...
1 year, 6 months ago #7
sky
LGTM
1 year, 6 months ago #8
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/10968049/8001
1 year, 6 months ago #9
I haz the power (commit-bot)
1 year, 6 months ago #10
Change committed as 158682
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6